Skip to content

Conversation

fgiannar
Copy link
Contributor

@fgiannar fgiannar commented Sep 17, 2025

This PR adds a new user property: is_connected to the user data we sync. This will be true if the user has connected their WPCOM account, false otherwise.
Having this info on WPCOM will allow us to fix a checksum inconsistency when calculating usermeta checksums on both ends plus potentially introduce automated connection error healing triggers when a user is connected on WPCOM but their token is missing from the remote site and vice-versa.

Full Context: SYNC-17

Proposed changes:

  • Automattic\Jetpack\Sync\Modules\Users: Update expand_user with an additional user property: is_connected. This will be true if the user has connected their WPCOM account, false otherwise.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

SYNC-17

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • See 192430-ghe-Automattic/wpcom

@fgiannar fgiannar self-assigned this Sep 17, 2025
@fgiannar fgiannar added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress labels Sep 17, 2025
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/sync-users-is_connected branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/sync-users-is_connected
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/sync-users-is_connected

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Package] Sync [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests labels Sep 17, 2025
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: October 7, 2025
    • Code freeze: October 6, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Sep 17, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/sync/src/modules/class-users.php 32/241 (13.28%) -0.06% 1 ❤️‍🩹

Full summary · PHP report · JS report

@fgiannar fgiannar added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Sep 17, 2025
@fgiannar fgiannar requested a review from bindlegirl September 17, 2025 12:24
@fgiannar fgiannar merged commit 550b9d7 into trunk Sep 18, 2025
94 checks passed
@fgiannar fgiannar deleted the update/sync-users-is_connected branch September 18, 2025 09:54
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 18, 2025
@github-actions github-actions bot added this to the jetpack/15.1 milestone Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Sync [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants