-
Notifications
You must be signed in to change notification settings - Fork 834
Jetpack Sync: Add 'is_connected' property to synced users #45210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
This PR adds a new user property:
is_connected
to the user data we sync. This will betrue
if the user has connected their WPCOM account,false
otherwise.Having this info on WPCOM will allow us to fix a checksum inconsistency when calculating usermeta checksums on both ends plus potentially introduce automated connection error healing triggers when a user is connected on WPCOM but their token is missing from the remote site and vice-versa.
Full Context: SYNC-17
Proposed changes:
Automattic\Jetpack\Sync\Modules\Users
: Updateexpand_user
with an additional user property:is_connected
. This will betrue
if the user has connected their WPCOM account,false
otherwise.Other information:
Jetpack product discussion
SYNC-17
Does this pull request change what data or activity we track or use?
No
Testing instructions: