Update `@wordpress/dataviews` from v7 to v9 #45213

simison · 2025-09-17T10:56:36Z

Update @wordpress/dataviews from v7 to v9.

See changelog for v8 and v9

Updates Forms to account for one breaking change:

DataViews: Custom empty elements are no longer wrapped in <p> tags to improve accessibility WordPress/gutenberg#71561

Proposed changes:

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Test plugins which had package.json updated

github-actions · 2025-09-17T10:57:32Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/wp-dataviews branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/wp-dataviews

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/wp-dataviews

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-09-17T10:57:38Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2025-09-17T11:13:59Z

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

manzoorwanijk · 2025-09-18T08:31:41Z

Instead of doing this manually, you can check the appropriate checkbox in #23363 to ensure that the dependency is updated everywhere. Then you can make the edits/fixes in the PR created by the renovate bot.

simison · 2025-09-18T09:20:08Z

@manzoorwanijk thanks! Yep I'm aware we have the Renovate bot flows, but recently I've been ahead of these updates by spinning up PRs before the stable release. I do this when we have product needs for the update from Forms, like this time with empty states or last time with improved mobile UX.

Otherwise, automated flows are fine. That said, I see nobody updated v8 meanwhile.

manzoorwanijk

Works fine for My Jetpack

simison · 2025-09-18T09:33:04Z

Locally getting built failure for Forms package at least:

$ jetpack build packages/forms --verbose

Click to expand

ERROR in ../../../node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/build-wp/index.js 481:0-71
[packages/forms] Module not found: Error: Can't resolve 'react-colorful' in 'jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/build-wp'
[packages/forms] resolve 'react-colorful' in 'jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/build-wp'
[packages/forms]   Parsed request is a module
[packages/forms]   using description file: jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/package.json (relative path: ./build-wp)
[packages/forms]     Field 'browser' doesn't contain a valid alias configuration
[packages/forms]     resolve as module
[packages/forms]       jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/build-wp/node_modules doesn't exist or is not a directory
[packages/forms]       looking for modules in jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/node_modules
[packages/forms]         single file module
[packages/forms]           using description file: jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/package.json (relative path: ./node_modules/react-colorful)
[packages/forms]             no extension
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/node_modules/react-colorful doesn't exist
[packages/forms]             .js
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/node_modules/react-colorful.js doesn't exist
[packages/forms]             .jsx
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/node_modules/react-colorful.jsx doesn't exist
[packages/forms]             .ts
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/node_modules/react-colorful.ts doesn't exist
[packages/forms]             .tsx
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/node_modules/react-colorful.tsx doesn't exist
[packages/forms]             .json
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/node_modules/react-colorful.json doesn't exist
[packages/forms]             .wasm
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/node_modules/react-colorful.wasm doesn't exist
[packages/forms]         jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/dataviews/node_modules/react-colorful doesn't exist
[packages/forms]       jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/@wordpress/node_modules doesn't exist or is not a directory
[packages/forms]       jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/node_modules doesn't exist or is not a directory
[packages/forms]       looking for modules in jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules
[packages/forms]         single file module
[packages/forms]           using description file: jetpack/package.json (relative path: ./node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/react-colorful)
[packages/forms]             no extension
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/react-colorful doesn't exist
[packages/forms]             .js
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/react-colorful.js doesn't exist
[packages/forms]             .jsx
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/react-colorful.jsx doesn't exist
[packages/forms]             .ts
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/react-colorful.ts doesn't exist
[packages/forms]             .tsx
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/react-colorful.tsx doesn't exist
[packages/forms]             .json
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/react-colorful.json doesn't exist
[packages/forms]             .wasm
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/react-colorful.wasm doesn't exist
[packages/forms]         jetpack/node_modules/.pnpm/@wordpress+dataviews@9.0.0_patch_hash=9971bdb899e2fb0a4421ab8b7f0a54a41f03b10ef1b51d729_04554428a5d3611c44063ae0baf7b304/node_modules/react-colorful doesn't exist
[packages/forms]       jetpack/node_modules/.pnpm/node_modules doesn't exist or is not a directory
[packages/forms]       jetpack/node_modules/node_modules doesn't exist or is not a directory
[packages/forms]       looking for modules in jetpack/node_modules
[packages/forms]         single file module
[packages/forms]           using description file: jetpack/package.json (relative path: ./node_modules/react-colorful)
[packages/forms]             no extension
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/react-colorful doesn't exist
[packages/forms]             .js
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/react-colorful.js doesn't exist
[packages/forms]             .jsx
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/react-colorful.jsx doesn't exist
[packages/forms]             .ts
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/react-colorful.ts doesn't exist
[packages/forms]             .tsx
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/react-colorful.tsx doesn't exist
[packages/forms]             .json
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/react-colorful.json doesn't exist
[packages/forms]             .wasm
[packages/forms]               Field 'browser' doesn't contain a valid alias configuration
[packages/forms]               jetpack/node_modules/react-colorful.wasm doesn't exist
[packages/forms]         jetpack/node_modules/react-colorful doesn't exist
[packages/forms]       node_modules doesn't exist or is not a directory
[packages/forms]       /Users/mikael/Documents/Work/node_modules doesn't exist or is not a directory
[packages/forms]       /Users/mikael/Documents/node_modules doesn't exist or is not a directory
[packages/forms]       /Users/mikael/node_modules doesn't exist or is not a directory
[packages/forms]       /Users/node_modules doesn't exist or is not a directory
[packages/forms]       /node_modules doesn't exist or is not a directory
[packages/forms]  @ ./src/dashboard/inbox/dataviews/index.js 18:0-52 286:34-43
[packages/forms]  @ ./src/dashboard/inbox/index.js 4:0-36 17:27-36
[packages/forms]  @ ./src/dashboard/index.tsx 14:0-28 42:33-38

manzoorwanijk · 2025-09-18T09:35:44Z

Locally getting built failure for Forms package at least:
$ jetpack build packages/forms --verbose

~~You might need to install react-colorful as a dependency.~~

manzoorwanijk · 2025-09-18T09:42:22Z

To fix the build error, simply make this change and run pnpm install

diff --git a/.pnpmfile.cjs b/.pnpmfile.cjs
index d4e605af23..83135ccf8d 100644
--- a/.pnpmfile.cjs
+++ b/.pnpmfile.cjs
@@ -16,6 +16,7 @@ const wpPkgs = {
                'highlight-words-core',
                'is-plain-object',
                'memize',
+               'react-colorful',
                '@use-gesture/react',
                'uuid',
                '@wordpress/date',

simison · 2025-09-18T09:57:02Z

Tested Forms works well.

dhasilva

LGTM. Tests well on My Jetpack and Forms. The other projects do not seem to actually use the package.

simison added [Status] In Progress [Type] Janitorial labels Sep 17, 2025

github-actions bot added [Feature] Contact Form [Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Publicize Components [JS Package] Scan [Package] Forms [Package] My Jetpack [Package] Subscribers Dashboard RNA labels Sep 17, 2025

simison force-pushed the update/wp-dataviews branch from 7cc04f8 to ae99ceb Compare September 18, 2025 08:28

simison requested a review from a team September 18, 2025 08:28

simison marked this pull request as ready for review September 18, 2025 08:28

simison requested a review from a team September 18, 2025 08:29

simison force-pushed the update/wp-dataviews branch from ae99ceb to 799e4a4 Compare September 18, 2025 09:20

simison added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Sep 18, 2025

manzoorwanijk reviewed Sep 18, 2025

View reviewed changes

simison force-pushed the update/wp-dataviews branch from 799e4a4 to 2046b57 Compare September 18, 2025 09:47

simison added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 18, 2025

simison added 5 commits September 18, 2025 14:39

Wrap empty messages in dataviews to p tag

3b83f31

Update packages

66af58b

changelogs

061c715

Update final versions

96461a6

Fix react-colorful dep

8f76176

simison force-pushed the update/wp-dataviews branch from 2046b57 to 8f76176 Compare September 18, 2025 11:43

dhasilva approved these changes Sep 18, 2025

View reviewed changes

simison merged commit 744b162 into trunk Sep 19, 2025
87 checks passed

simison deleted the update/wp-dataviews branch September 19, 2025 06:03

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update `@wordpress/dataviews` from v7 to v9 #45213

Update `@wordpress/dataviews` from v7 to v9 #45213

Uh oh!

simison commented Sep 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

jp-launch-control bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

manzoorwanijk commented Sep 18, 2025

Uh oh!

simison commented Sep 18, 2025

Uh oh!

manzoorwanijk left a comment

Uh oh!

simison commented Sep 18, 2025 •

edited by manzoorwanijk

Loading

Uh oh!

manzoorwanijk commented Sep 18, 2025 •

edited

Loading

Uh oh!

manzoorwanijk commented Sep 18, 2025

Uh oh!

simison commented Sep 18, 2025

Uh oh!

dhasilva left a comment

Uh oh!

Uh oh!

Uh oh!

Update @wordpress/dataviews from v7 to v9 #45213

Update @wordpress/dataviews from v7 to v9 #45213

Uh oh!

Conversation

simison commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

jp-launch-control bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

manzoorwanijk commented Sep 18, 2025

Uh oh!

simison commented Sep 18, 2025

Uh oh!

manzoorwanijk left a comment

Choose a reason for hiding this comment

Uh oh!

simison commented Sep 18, 2025 • edited by manzoorwanijk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manzoorwanijk commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manzoorwanijk commented Sep 18, 2025

Uh oh!

simison commented Sep 18, 2025

Uh oh!

dhasilva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Update `@wordpress/dataviews` from v7 to v9 #45213

Update `@wordpress/dataviews` from v7 to v9 #45213

simison commented Sep 17, 2025 •

edited

Loading

github-actions bot commented Sep 17, 2025 •

edited

Loading

jp-launch-control bot commented Sep 17, 2025 •

edited

Loading

simison commented Sep 18, 2025 •

edited by manzoorwanijk

Loading

manzoorwanijk commented Sep 18, 2025 •

edited

Loading