Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: useConnection(connection) function #14802

Open
wants to merge 4 commits into
base: 8.8
Choose a base branch
from
Open

feat: useConnection(connection) function #14802

wants to merge 4 commits into from

Conversation

IslandRhythms
Copy link
Collaborator

No description provided.

vkarpov15
vkarpov15 requested changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More testing required. Also please add TypeScript type definition and TypeScript test please

test/model.test.js Outdated Show resolved Hide resolved
lib/model.js Show resolved Hide resolved
@vkarpov15 vkarpov15 marked this pull request as draft August 20, 2024 21:44
@vkarpov15 vkarpov15 changed the base branch from 8.6 to 8.8 October 26, 2024 18:04
@vkarpov15 vkarpov15 marked this pull request as ready for review October 26, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IslandRhythms @vkarpov15