fix: minor bug fixes (#21)

* fix: avoid a PHP warning when updating a non-single meta value * fix: "listing type" should be a sort option by default * refactor: remove unnecessary isset() call
Automattic · Dec 18, 2020 · 5f90bc7 · 5f90bc7
1 parent 6c47a17
commit 5f90bc7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/includes/newspack-listings-utils.php b/includes/newspack-listings-utils.php
@@ -107,7 +107,7 @@ function get_data_from_blocks( $blocks, $source ) {
 		}
 
 		// If the source has 'single' specified, only get data from the first found block instance.
-		if ( $source['single'] ) {
+		if ( ! empty( $source['single'] ) ) {
 			$matching_blocks = array_slice( $matching_blocks, 0, 1 );
 		}
 
@@ -138,7 +138,7 @@ function get_data_from_blocks( $blocks, $source ) {
 	}
 
 	// If the source has 'single' specified, only return data from the first found block instance.
-	if ( $source['single'] ) {
+	if ( ! empty( $source['single'] ) ) {
 		return array_shift( $data );
 	}
 

diff --git a/src/components/sidebar-query-controls.js b/src/components/sidebar-query-controls.js
@@ -188,7 +188,7 @@ class QueryControls extends Component {
 		}
 
 		// Enable listing type option only if there's more than one listing type in the list.
-		if ( 'any' === type ) {
+		if ( 'any' === type || ! type ) {
 			sortOptions.push( { label: __( 'Listing Type', 'newspack-listings' ), value: 'type' } );
 		}