Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quick actions edit mode #3777

Open
wants to merge 1 commit into
base: epic/ia
Choose a base branch
from

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented Feb 24, 2025

All Submissions:

Changes proposed in this Pull Request:

NOTE: This is an experiment—feel free to disregard this PR if you find the implementation lacking.

This PR improves the Quick Actions section in the dashboard and allows publisher to custom them via drag and drop.

  • Added a maximum of 3 active Quick Actions with drag-and-drop functionality
  • Wobble animation during editing and improved button styles
  • Added "Reset to default" option and proper cancel functionality
newspack-edit-quick-action.mp4

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. Locate the Quick Actions section in the dashboard.
  3. Edit the actions, using drag and drop. Remove/add, play with it.
  4. Does it save properly (refresh the page to check)
  5. Restore to default and save (refresh the page to check)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot force-pushed the add/quick-actions-edit branch 5 times, most recently from 4fba25b to 16b6936 Compare February 25, 2025 07:13
@thomasguillot thomasguillot added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 25, 2025
@thomasguillot thomasguillot marked this pull request as ready for review February 25, 2025 07:31
@thomasguillot thomasguillot requested a review from a team as a code owner February 25, 2025 07:31
@leogermani
Copy link
Contributor

I love this. I'd say let's wait for IA to be deployed, since testing is already underway, and we can circle back to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants