Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rss-feed): Add Feed enhancements for Republications. #3801

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

Takshil-Kunadia
Copy link
Collaborator

@Takshil-Kunadia Takshil-Kunadia commented Mar 6, 2025

All Submissions:

Changes proposed in this Pull Request:

Addresses https://app.asana.com/0/0/1209344511155915/f .

  1. Add relevant options to the RSS Feed settings, if the Republication tracker plugin is activated:
    • A checkbox to add a republication tracker snippet to posts.
    • A checkbox to filter the feed to only include republishable posts.
    • A select field to choose between RSS and Atom feed formats.
  2. When the user selects the Atom feed format, the "Wrap the content of <title> elements in CDATA tags" option is disabled and forced to false (since WordPress Atom feeds encoded title by default).
  3. Adjusts the feed URL generation and query modifications to reflect the selected feed format.
  4. Outputs the <republication_tracker> tag in the feed when the tracker option is enabled.
  5. Modifies the meta query so that only posts not marked to hide the republishing button are included when filtering is active.

How to test the changes in this Pull Request:

  1. Install & Configure Republication Tracker Tool.
  2. Create Feeds from Admin > RSS Feeds.
  3. Check for new options.
    • Checkbox for adding republication tracker pixel.
    • Checkbox for only including republishable posts.
    • Select for RSS or Atom feeds.
  4. Try the above settings and check the feed link generated.
  5. If republication tracker pixel checkbox is clicked a <republication_tracker> tag is included adding the tracking pixel.
  6. If only Include Republishable posts checkbox is added, only posts which have "Hide Republishing Button" metabox checkbox unchecked will be included.
  7. RSS & Atom feeds will be displayed based on the selected feed type.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@Takshil-Kunadia Takshil-Kunadia marked this pull request as ready for review March 6, 2025 09:32
@Takshil-Kunadia Takshil-Kunadia requested a review from a team as a code owner March 6, 2025 09:32
@@ -342,9 +349,22 @@ public static function render_content_settings_metabox( $feed_post ) {
</table>

<script>
const handleCDATA = function() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant