Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google-site-kit): handle new analytics option name #3802

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Mar 6, 2025

All Submissions:

Changes proposed in this Pull Request:

Google Site Kit has update the Analytics settings option name in v.1.123.0, this PR ensures Newspack's overwrite of these settings is handled for the new option name, too.

How to test the changes in this Pull Request:

  1. On release, set up a new site and set up Site Kit with Analytics
  2. In Site Kit -> Settings -> Analytics, observe the "Excluded from Analytics" setting has "All logged-in users" value
  3. Switch to this branch, observe the value is now "Users that can write posts"

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 6, 2025
@adekbadek adekbadek requested a review from a team as a code owner March 6, 2025 11:18
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants