Lint fixes!

Automattic · Jan 19, 2024 · 3183235 · 3183235
1 parent e7d8ae9
commit 3183235
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/Simplenote/src/main/java/com/automattic/simplenote/StyleActivity.java b/Simplenote/src/main/java/com/automattic/simplenote/StyleActivity.java
@@ -152,9 +152,9 @@ public void onBindViewHolder(@NonNull final StyleHolder holder, final int positi
                     public void onClick(View v) {
                         if (mIsPremium) {
                             notifyItemChanged(mSelectedPosition);
-                            mSelectedPosition = position;
+                            mSelectedPosition = holder.getAdapterPosition();
                             notifyItemChanged(mSelectedPosition);
-                            PrefUtils.setStyleIndex(StyleActivity.this, position);
+                            PrefUtils.setStyleIndex(StyleActivity.this, holder.getAdapterPosition());
                         } else if (holder.mLocked.getVisibility() == View.VISIBLE) {
                             showDialogLocked();
                         }

diff --git a/Simplenote/src/main/java/com/automattic/simplenote/billing/SubscriptionDurationAdapter.kt b/Simplenote/src/main/java/com/automattic/simplenote/billing/SubscriptionDurationAdapter.kt
@@ -1,5 +1,6 @@
 package com.automattic.simplenote.billing
 
+import android.annotation.SuppressLint
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
@@ -56,6 +57,7 @@ class SubscriptionDurationAdapter :
             return oldItem.offerId == newItem.offerId
         }
 
+        @SuppressLint("DiffUtilEquals")
         override fun areContentsTheSame(
             oldItem: IapViewModel.PlansListItem,
             newItem: IapViewModel.PlansListItem

diff --git a/Simplenote/src/main/java/com/automattic/simplenote/utils/ThemeUtils.java b/Simplenote/src/main/java/com/automattic/simplenote/utils/ThemeUtils.java
@@ -107,8 +107,7 @@ public static int getThemeTextColorId(Context context) {
             return 0;
         }
 
-        int[] attrs = {R.attr.noteEditorTextColor};
-        TypedArray ta = context.obtainStyledAttributes(attrs);
+        TypedArray ta = context.obtainStyledAttributes(new int[]{R.attr.noteEditorTextColor});
         int textColorId = ta.getResourceId(0, android.R.color.black);
         ta.recycle();