Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Simperium dependency and upgrade to SDK 33 #1612

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

danilo04
Copy link
Contributor

@danilo04 danilo04 commented Oct 10, 2023

Fix

Fixes #1611.

Simperium PR: Simperium/simperium-android#248.

On Simplenote, we get crashes when a note is big and exceeds the SQLite row size (2 MB). We are going to catch SQLException and return a missing object for the cases in which we get an exception.

Test

Smoke test the whole app:

  1. Test login
  2. Test adding a new note and check that the note is synced and available in other devices (you can try the web app https://app.simplenote.com/)
  3. Test adding notes from the web app and check that they are visible on the Android device.
  4. Try adding tasks lists and checking their boxes. Check that the updates are seen in other devices.
  5. Try adding a collaborator and check that the user you share the note to receives an email.
  6. Try adding note references in your note. Type [title of note] to see if you get a list of possible notes to link.
  7. Try adding, editing and deleting tags.
  8. Try searching for notes.
  9. Try changing the theme.
  10. Try changing the font size and see that the note list and the notes font size (in the editor) use the font size set.
  11. Try setting up a lock screen in Settings. Leave the app and then enter it again using the code you setup.
  12. Try publishing a note. Go to a note and tap on the top-right menu and tap.
  13. Try to reverse a note to an earlier revision. Tap on the top-right menu and then tap on History. Change the slider to different versions and see how the note changes. Select one version and see that the note is updated to that version on other devices.

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated in 21e349f with:

Fixed crashes when a big note is tried to be synced.

@danilo04 danilo04 added [Type] Bug Something isn't working. crash Bad stuff — something related to an app crash! labels Oct 10, 2023
@danilo04 danilo04 marked this pull request as ready for review October 10, 2023 15:31
@danilo04 danilo04 requested a review from khaykov October 10, 2023 15:31
@khaykov khaykov self-assigned this Oct 10, 2023
Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @danilo04 ! I tested with release build, and everything appears to be working. Looks like the build is failing for some reason tho.

@wpmobilebot
Copy link
Collaborator

You can test the changes on this Pull Request by downloading an installable build (simplenote-android-installable-build-pr1612-aea8330-018b1b02-2bd8-4998-87f3-03cc51bdb8a9.apk), or scanning this QR code:

@danilo04 danilo04 merged commit 07b76ad into trunk Oct 10, 2023
9 checks passed
@danilo04 danilo04 deleted the issue/1611-crash-sqliteexception branch October 10, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Bad stuff — something related to an app crash! [Type] Bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLiteBlobTooBigException: Row too big to fit into CursorWindow requiredPos=0, totalRows=1
3 participants