Extract create backmerge PR methods in helper files #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
force-pushed
the
mokagio/fix-backmerge-annotation
branch
from
a718d11
to
e103a9c
Compare
|
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
|
mokagio
added
the
tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
What it says in the title. This is a followup to the discussion with @iangmaia here: #1695 (comment)
Test
This is tricky to test outside the release cycle. I checked out a test branch, added a lane that calls the method and saw it go through the expected steps, which was enough to verify everything is at least wired in a way that Ruby can interpret.
Review
Only one infra engineer required to review these changes, but anyone can perform the review.
Release
These changes do not require release notes.