Bugfix for Shortcode content gets injected with pre tags by tinymce #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow block-level elements as valid children of pre to stop tinymce from segmenting shortcodes.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Shortcodes get injected with pre tags by tinymce when block-level html is included.
Steps to reproduce:
Example short code
[html]<h1>This is an h1</h1>[html]Expected output:
The user should be able to switch tiny mce modes (text/visual) and the content should not have code injected at the very least.
Actual Output:
Since SH passes unescaped html to the editor and wraps the shortcode in pre tags, tiny mce breaks up the shortcode in to segments injecting closing and opening pre tags to exclude the block level element from the pre content.
Tested with: WordPress 3.6-beta3-24430