Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump required PHP versions to 7.2 #8589

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Bump required PHP versions to 7.2 #8589

merged 2 commits into from
Jan 22, 2025

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jan 16, 2025 •
edited
Loading

Changes proposed in this Pull Request:

Part of #7785.

5.x, 7.0, and 7.1 are all bumped to 7.2

WordPress requires at least PHP 7.2 since WordPress version 6.6.

These files are not touched and do not appear to have any required PHP version and have no inactive status annotation:

altofocus
alves
apostrophe-2
balasana
barnsbury
button-2
canard
coutoire
dalston
dara
dyad-2
exford
gazette
hever
ibis
illustratr
independent-publisher-2
intergalactic-2
ixion
karuna
leven
libre-2
libretto
lodestar
mayland
maywood
morden
penscratch-2
photos
pique
publication
radcliffe-2
rebalance
rivington
rockfield
scratchpad
shawburn
shoreditch
sketch
stow
stratford
textbook
toujours
varia

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Preview changes

I've detected changes to the following themes in this PR: Adonay, Adventurer, Aether, Aigoo, Al Dente, AlleyOop, Allez, Alter, Ames, Antonia, Appleton, Arbutus, Archeo, Archivo, Artly, Assembler, Attar, Awburn, Azur, Bain Marie, Bark, Barnett, Barnsbury23, Batch, Bedrock, Beep, Bennett, Bibimbap, Bibliophile, Bitácora, Blank Canvas, Blank Canvas, Blank Canvas, Blissed, Block Canvas, Blockbase, Blogorama, Boxed Bio, Brightblog, Brute, BSoJ, Bute, Bysshe, Cakely, Calvin, Calyx, CastCore, Casthub, Chanson, CoachAva, CoachBen, Colorloops, Colorstream, Common, Conference, Cookbook, Cortado, Cottage, Course, Covr, Craftfully, Creatio 2, Creatio, CTLG, Cubico, Curriculum, Dadaist, Dark Academia, Dawson, Didone, Disco, Dorna, DOS, Dossier, Downtown, Dropp, Entry, Epi, Erma, Eventual, Exmoor, Farrow, Feature, Feelin'Good, Fewer, Fictionary, Fixmate, Foam, Fontaine, Fotograma, Freddie, Geologist, Goodskin, Grammer One, Greenseed, Happening, Hari, Heiwa, Hey, Hola, Ici, Impressionist, Indice, Infield, Inversum, Iotix, Issue, Jackson, Jaida, JazzyGrid, Jenn, JinJang, Kamala, Kansei, Kawaii-Chan, Kaze, Kentwood, Kigen, Kingsley, Kiosko, Koinonia, Lativ, LeanCV, Lettre, Lineup, Livro, Loïc, lois, Loudness, LowFi, Luce, Luminance, Luxus, Lynx, Mann, Margarethe, Marl, Massimo, Masu, Matrioska, Maverick, Mayland (Blocks), Meraki, Message, Messagerie, Miko, Montagna, Mpho, Muscat, Musee, Mysa, Negai, Nested, Nook, Olympique, OnyxPulse, Optimismo, Organizer, Otis, OutNow, Overlaid, Paimio, Partygurl, Pendant, Perenne, Pieria, Pixl, Podbase, Poema, Poesis, Pomme, Portia, Professio, Programme, Promoter, Psychedeli, Quadrat, Raconteur, Rainfall, RAW, RecipeBook, Remote, Reverie, Ritratto, Ron, Russell, Saison, Screenplay, Seedlet (Blocks), Seedlet, Shhh, Skatepark, SND, Spearhead, Spearhead (Classic), Specials, Spiel, Sprinkler, Stage, Stageplay, StartFit, Startorg, Sten, Stewart, Storia, Strand, Streamer, Sunderland, Surrealist, Tenaz, Texty, The Jazzers, The MENU, The Shore, TieBreak, Tomoni, Trellick, Tronar, Tú, Twenty Twenty-Two (Blue), Twenty Twenty-Two (Mint), Twenty Twenty-Two (Pink), Twenty Twenty-Two (Red), Twenty Twenty-Two (Swiss), Ueno, Upsidedown, Urbem, Verso, Vetro, Vibrrrant, Vitrum, Vivre, Vueo, Winkel, WP-DOS, Xanadu, Zoologist.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.
Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

@sirreal sirreal marked this pull request as ready for review January 16, 2025 15:55
@sirreal sirreal mentioned this pull request Jan 16, 2025
Open
sixhours
sixhours approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrolled through and confirmed this only updates the Requires PHP values to 7.2 for each of these themes' stylesheets.

@sirreal
Copy link
Member Author

sirreal commented Jan 16, 2025

Thanks @sixhours! I'd appreciate it if you (or someone) could help to merge and deploy this, I haven't worked on this and I'm not confident in what the workflow is.

@sixhours
Copy link
Contributor

Thanks @sixhours! I'd appreciate it if you (or someone) could help to merge and deploy this, I haven't worked on this and I'm not confident in what the workflow is.

I'm not, either, but @alaczek has merged a few of mine recently so it's likely she will know! IIRC there's a special process for deploying multiple themes at the same time.

@alaczek
Copy link
Contributor

alaczek commented Jan 17, 2025

Hmm... I don't know if I ever handled this many themes at once, and it makes me a little nervous. @dsas maybe you could help out?

@dsas
Copy link
Contributor

dsas commented Jan 17, 2025

I am sure that it's untested with this number of themes, but I don't know of any reason why the standard process (PNEWy-eqL-p2) wouldn't work :)

I can try to give it a run later today

@gziolo
Copy link
Member

gziolo commented Jan 20, 2025

As of WordPress 6.7, the minimum required PHP version is 7.4. See https://wordpress.org/about/requirements/.

@sirreal
Copy link
Member Author

sirreal commented Jan 20, 2025 •
edited
Loading

The table at "PHP Compatibility and WordPress Versions" still lists support for 7.3 and 7.2 for WordPress 6.7. One of the sources is out of date:

Screenshot 2025-01-20 at 13 51 04

@gziolo
Copy link
Member

gziolo commented Jan 20, 2025

I noticed that there is a remark on the page I shared:

Note: If you are in a legacy environment where you only have older PHP or MySQL versions, WordPress also works with PHP 7.2.24+ and MySQL 5.5.5+. However, these versions have reached their official End Of Life and may expose your site to security vulnerabilities.

We might expect them to drop the official support for PHP 7.2 when its usage drops more significantly.

@dsas dsas force-pushed the update/php-version-7.2 branch from dc6e1f4 to 8fbccbb Compare January 22, 2025 19:43
@dsas dsas merged commit 23d29f3 into trunk Jan 22, 2025
1 of 2 checks passed
@dsas dsas deleted the update/php-version-7.2 branch January 22, 2025 20:58
dsas added a commit that referenced this pull request Jan 22, 2025
@dsas
Revert "Bump required PHP versions to 7.2 (#8589)"
a8cdada 
This reverts commit 23d29f3.

The change is sound, however deploying this many themes in one go is painful, for several reasons:

 * The deploy script makes multiple ssh requests to the sandbox for each
   theme to be deployed. This will be very slow.
 * By default, the deploy script will add strict_types to lots of themes
   at once, if say 5% of them have bugs, that's still 11 themes to
   urgently fix
 * The deploy script will create one big PR, merge it, and then if it
   doesn't deploy all 230+ themes within a few minutes, it will start
   triggering slow deployment alarms.
@dsas dsas restored the update/php-version-7.2 branch January 22, 2025 23:24
@dsas
Copy link
Contributor

dsas commented Jan 22, 2025

Hmm... I don't know if I ever handled this many themes at once, and it makes me a little nervous. @dsas maybe you could help out?

I merged the branch to this repo, gave it a try and cancelled before it did anything permanent. I've reverted the merge.

Changing this many themes at once is a bit of a problem

  1. The deploy script makes multiple ssh requests to the sandbox for each theme to be deployed. This will be very slow but not a problem per se.
  2. By default, the deploy script will add strict_types to lots of themes at once. It's unlikely for block themes to have a bug but not all themes are block themes, and if say 5% of themes have bugs, that's still 11 themes to urgently fix.
  3. The deploy script will create one big PR, merge it, and then if it doesn't deploy all 230+ themes within a few minutes, it will start triggering slow deployment alarms. Merging and deploying one theme can take a couple of minutes. If we deploy this many themes at once we might block all deployments for hours
  4. Several themes had unexpected changes:
  • Adventurer - search pattern modified
  • miko - yuzu style variation deleted
  • muscat - various changes to patterns and parts
  • seedlet - changes on ghe that need copying down to this repo

It might be better to resolve the issues with the four themes above, then batch this pr into several smaller PRs.

@alaczek
Copy link
Contributor

alaczek commented Jan 23, 2025

Just wondering - would it make sense to also update this info in readme.txt files?

@sirreal sirreal deleted the update/php-version-7.2 branch January 23, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixhours sixhours sixhours approved these changes

@mikachan mikachan Awaiting requested review from mikachan

@iamtakashi iamtakashi Awaiting requested review from iamtakashi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sirreal @sixhours @alaczek @dsas @gziolo