Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoologist: Correct color classes for foreground and secondary #8595

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

pkevan
Copy link
Contributor

@pkevan pkevan commented Jan 17, 2025

Fixes #5787.

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Zoologist.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.
Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

Copy link
Contributor

Theme-Check results

zoologist: There are required changes on the theme ❌.

❎ REQUIRED

  • This theme text domain does not match the theme's slug. The text domain used: blockbase, ) This theme's correct slug and text-domain is zoologist.
💡 RECOMMENDED (1)
  • Possible variable $header_pattern found in translation function in inc/block-patterns.php. Translation function calls must not contain PHP variables, use placeholders instead. See Internationalization Guidelines (Opens in a new window). Line 39: $header_patterns = array(Line 48: foreach ( $header_patterns as $header_pattern ) {Line 50: 'blockbase/header-' . $header_pattern,Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ),Line 55: 'content' => file_get_contents (get_theme_file_path( '/parts/header-' . $header_pattern . '.html' )),
⚠️ WARNING (3)
  • Found a translation function that has an incorrect number of arguments in the file inc/block-patterns.php. Function __, with the arguments 'Blockbase Header (', ), 'blockbase'. Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ),
  • Found a translation function that is missing a text-domain in the file inc/customizer/wp-customize-fonts.php. Function __, with the arguments 'https://wordpress.com/support/custom-fonts/'. Line 13: __( 'https://wordpress.com/support/custom-fonts/' )
  • More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are blockbase, ).

Comment on lines -81 to +84
"foreground": "var(--wp--preset--color--primary)",
"foreground": "var(--wp--preset--color--foreground)",
"background": "var(--wp--preset--color--background)",
"primary": "var(--wp--preset--color--primary)",
"secondary": "var(--wp--preset--color--primary)",
"secondary": "var(--wp--preset--color--secondary)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think quadrat and geologist needs the same change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there are a few of these - i'll go through and create some PRs to fix the ones I see.

@pkevan pkevan merged commit 03ca487 into trunk Jan 23, 2025
2 of 5 checks passed
@pkevan pkevan deleted the fix/issue-5787 branch January 23, 2025 10:02
cbravobernal added a commit that referenced this pull request Jan 24, 2025
cbravobernal added a commit that referenced this pull request Jan 24, 2025
* Revert "fix color classes (#8616)"

This reverts commit bf0fb83.

* Revert "correct color classes for foreground and secondary (#8595)"

This reverts commit 03ca487.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoologist: Secondary color not being applied to header or paragraph block
2 participants