Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scratchpad: Fix margin top-bottom on frontend #8600

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

cbravobernal
Copy link
Contributor

Changes proposed in this Pull Request:

Related issue(s):

Fixes this issue only in the Scratchpad theme.

#6611

How to test it

Before the PR:

  • Use Scratchpad theme.
  • Create or edit a page, add a couple of images on the editor.
  • Check that there is a margin in the editor.
  • Preview or publish the page, check that there are no margins.
    Screenshot 2025-01-20 at 17 38 54

After the PR:

  • Preview or publish the page, check that there are margins.

Screenshot 2025-01-20 at 17 38 32

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Preview changes

I've detected changes to the following themes in this PR: Scratchpad.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@cbravobernal cbravobernal requested a review from macmanx2 January 20, 2025 16:39
@cbravobernal cbravobernal self-assigned this Jan 20, 2025
@cbravobernal cbravobernal added the [Type] Bug Something isn't working label Jan 20, 2025
Copy link
Contributor

Theme-Check results

scratchpad: There are required changes on the theme ❌.

❎ REQUIRED

  • Could not find wp_body_open action or function call at the very top of the body just after the opening body tag. See: wp_body_open
  • HEADER_TEXTCOLOR was found in the file inc/custom-header.php. Use add_theme_support( 'custom-header' ) instead. Line 48: if ( HEADER_TEXTCOLOR === $header_text_color ) {
  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).
  • Tested up to: is missing from your style.css header. Also, this should be numbers only, so 5.0 and not WP 5.0
  • Requires PHP: is missing from your style.css header.
💡 RECOMMENDED (6)
  • No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • No reference to add_theme_support( "custom-logo", $args ) was found in the theme. It is recommended that the theme implement this functionality.
  • No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.
  • No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.
⚠️ WARNING (5)
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Color 1'. Line 219: __( 'Color 1' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Color 2'. Line 271: __( 'Color 2' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Color 3'. Line 305: __( 'Color 3' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Color 4'. Line 358: __( 'Color 4' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Color 5'. Line 452: __( 'Color 5' ) );

@cbravobernal cbravobernal requested a review from mikachan January 21, 2025 10:19
Copy link
Contributor

@pkevan pkevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as same as: #8594

@cbravobernal cbravobernal merged commit a11c274 into trunk Jan 23, 2025
1 of 2 checks passed
@cbravobernal cbravobernal deleted the fix/scratchpad-block-image-margin branch January 23, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Scratchpad [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants