-
Notifications
You must be signed in to change notification settings - Fork 72
Fix WooPay issue with single use coupons #11052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Errors on workflows looks related to some dependency that is currently down. |
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 871 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I set the coupon and the per user limit the checkout still fails. So we'll need to add another filter to skip the get_usage_limit_per_user
too.
@leonardola fixed on 8d1380c, updated the testing instructions. |
Fixes WOOPAY-365
Changes proposed in this Pull Request
This PR fixes issues when checking out with WooPay while using single use coupons.
This happens because coupons with usage limit were getting holded during the WooPay preflight check, this incremented the
$tentative_usage_count
here causing an error on the WooPay actual checkout request.Testing instructions
Redo the test with single use per user coupon and both.
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge