Replace u64 with i64 in wp_mobile_cache and wp_mobile crates
#1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates unnecessary casting between rusqlite's `i64` and our `u64` types. Since rusqlite consistently uses `i64` for all integer operations, aligning our types reduces friction and improves code clarity. Changes: - Change `RowId` inner type from `u64` to `i64` - Remove casting in `RowId`'s `ToSql`, `FromSql`, and conversion implementations - Update migration functions to use `i64` instead of `u64` - Change `FetchResult.total_items` from `Option<u64>` to `Option<i64>` - Remove unnecessary casts in repository and service code - Update type casts in test code and helper functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates unnecessary casting between rusqlite's
i64and ouru64types. Since rusqlite consistently usesi64for all integer operations, aligning our types reduces friction and improves code clarity.Changes:
RowIdinner type fromu64toi64RowId'sToSql,FromSql, and conversion implementationsi64instead ofu64FetchResult.total_itemsfromOption<u64>toOption<i64>