Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calypso UI Components: DateRange: Move Buttons to Bottom #94523

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

annacmc
Copy link
Contributor

@annacmc annacmc commented Sep 13, 2024

Related to https://github.com/Automattic/red-team/issues/135

Note:

  • This whole area is known as the header. The renderHeader function is built into it. It is no longer being used as a "header" so in the next follow PR I will be refactoring for this.

Why are these changes being made?

  • To extend the Calypso DateRange picker component for use with the Stats Date Control update.

Testing Instructions

  • open Calypso live branch
  • navigate to /devdocs/design/date-range
  • click on any of the demos
  • check that the cancel + apply buttons display below the calendars now
  • also thoroughly check on mobile and small displays

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@annacmc annacmc self-assigned this Sep 13, 2024
@annacmc annacmc added the Stats Everything related to our analytics product at /stats/ label Sep 13, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2024

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@annacmc annacmc force-pushed the update/calypso-ui-component-daterange-layout branch from 2866358 to 4c7921f Compare September 15, 2024 23:52
@matticbot
Copy link
Contributor

matticbot commented Sep 16, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/calypso-ui-component-daterange-layout on your sandbox.

@annacmc annacmc marked this pull request as ready for review September 16, 2024 04:18
@annacmc annacmc requested a review from a team September 16, 2024 04:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 16, 2024
@annacmc annacmc force-pushed the update/calypso-ui-component-daterange-layout branch from 75db8a2 to a3adccd Compare September 16, 2024 06:22
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@annacmc annacmc merged commit c1131d1 into trunk Sep 16, 2024
11 checks passed
@annacmc annacmc deleted the update/calypso-ui-component-daterange-layout branch September 16, 2024 07:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants