Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: add Zendesk chat second method #94701

Closed
wants to merge 1 commit into from

Conversation

arcangelini
Copy link
Contributor

DO NOT MERGE

Related to #94643

Proposed Changes

Adds Zendesk to Odie Client

Screen Shot 2024-09-17 at 22 32 08

Why are these changes being made?

Because one popup is better than 2

Testing Instructions

No need to test, everything works... I promise

@arcangelini arcangelini requested a review from a team as a code owner September 19, 2024 08:22
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2024
@arcangelini arcangelini requested review from AllTerrainDeveloper and bcotrim and removed request for a team September 19, 2024 08:29
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~281 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
site-purchases                          +475 B  (+0.0%)      +47 B  (+0.0%)
purchases                               +475 B  (+0.0%)      +47 B  (+0.0%)
import-hosted-site-flow                 +475 B  (+0.1%)      +45 B  (+0.0%)
email                                   +475 B  (+0.1%)      +62 B  (+0.0%)
domains                                 +475 B  (+0.0%)      +37 B  (+0.0%)
update-design-flow                      +274 B  (+0.0%)      +46 B  (+0.0%)
plans                                   +274 B  (+0.0%)      +18 B  (+0.0%)
link-in-bio-tld-flow                    +274 B  (+0.0%)      +29 B  (+0.0%)
jetpack-connect                         +274 B  (+0.0%)      +18 B  (+0.0%)
jetpack-cloud-pricing                   +274 B  (+0.0%)      +18 B  (+0.0%)
jetpack-cloud-features-comparison       +274 B  (+0.0%)      +18 B  (+0.0%)
copy-site-flow                          +274 B  (+0.0%)      +20 B  (+0.0%)
checkout                                +274 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~12780 bytes added 📈 [gzipped])

name                                                            parsed_size           gzip_size
async-load-automattic-help-center                                  +21235 B  (+3.8%)   +12682 B  (+7.7%)
async-load-signup-steps-woocommerce-install-transfer                 +274 B  (+0.9%)      +46 B  (+0.5%)
async-load-signup-steps-woocommerce-install-step-store-address       +274 B  (+0.4%)      +46 B  (+0.2%)
async-load-signup-steps-woocommerce-install-step-business-info       +274 B  (+0.3%)      +46 B  (+0.2%)
async-load-signup-steps-woocommerce-install-confirm                  +274 B  (+0.5%)      +46 B  (+0.3%)
async-load-signup-steps-website-content                              +274 B  (+0.3%)      +46 B  (+0.1%)
async-load-signup-steps-user                                         +274 B  (+0.2%)      +46 B  (+0.1%)
async-load-signup-steps-theme-selection                              +274 B  (+0.1%)      +46 B  (+0.0%)
async-load-signup-steps-test-step                                    +274 B  (+1.3%)      +46 B  (+0.7%)
async-load-signup-steps-subscribe-email                              +274 B  (+0.2%)      +46 B  (+0.1%)
async-load-signup-steps-store-features                               +274 B  (+0.6%)      +46 B  (+0.3%)
async-load-signup-steps-starting-point                               +274 B  (+0.8%)      +46 B  (+0.4%)
async-load-signup-steps-social-profiles                              +274 B  (+1.0%)      +46 B  (+0.5%)
async-load-signup-steps-site-picker                                  +274 B  (+0.2%)      +46 B  (+0.1%)
async-load-signup-steps-site-or-domain                               +274 B  (+0.7%)      +46 B  (+0.4%)
async-load-signup-steps-site-options                                 +274 B  (+0.7%)      +46 B  (+0.4%)
async-load-signup-steps-site                                         +274 B  (+0.6%)      +46 B  (+0.4%)
async-load-signup-steps-rewind-were-backing                          +274 B  (+1.2%)      +46 B  (+0.6%)
async-load-signup-steps-rewind-form-creds                            +274 B  (+0.4%)      +46 B  (+0.2%)
async-load-signup-steps-reader-landing                               +274 B  (+1.1%)      +46 B  (+0.6%)
async-load-signup-steps-plans-theme-preselected                      +274 B  (+0.1%)      +46 B  (+0.0%)
async-load-signup-steps-plans                                        +274 B  (+0.1%)      +46 B  (+0.0%)
async-load-signup-steps-page-picker                                  +274 B  (+0.1%)      +46 B  (+0.0%)
async-load-signup-steps-p2-site                                      +274 B  (+0.5%)      +46 B  (+0.3%)
async-load-signup-steps-p2-join-workspace                            +274 B  (+0.9%)      +46 B  (+0.5%)
async-load-signup-steps-p2-details                                   +274 B  (+1.1%)      +46 B  (+0.6%)
async-load-signup-steps-p2-confirm-email                             +274 B  (+1.1%)      +46 B  (+0.5%)
async-load-signup-steps-p2-complete-profile                          +274 B  (+0.3%)      +46 B  (+0.2%)
async-load-signup-steps-new-or-existing-site                         +274 B  (+0.6%)      +46 B  (+0.3%)
async-load-signup-steps-intent                                       +274 B  (+0.7%)      +46 B  (+0.4%)
async-load-signup-steps-initial-intent                               +274 B  (+0.3%)      +46 B  (+0.2%)
async-load-signup-steps-hosting-decider                              +274 B  (+1.3%)      +46 B  (+0.6%)
async-load-signup-steps-emails                                       +274 B  (+0.4%)      +46 B  (+0.2%)
async-load-signup-steps-difm-site-picker                             +274 B  (+0.2%)      +46 B  (+0.1%)
async-load-signup-steps-design-picker                                +274 B  (+0.5%)      +46 B  (+0.3%)
async-load-signup-steps-creds-permission                             +274 B  (+0.5%)      +46 B  (+0.3%)
async-load-signup-steps-creds-confirm                                +274 B  (+0.5%)      +46 B  (+0.3%)
async-load-signup-steps-courses                                      +274 B  (+0.8%)      +46 B  (+0.4%)
async-load-signup-steps-clone-start                                  +274 B  (+1.0%)      +46 B  (+0.5%)
async-load-signup-steps-clone-ready                                  +274 B  (+0.5%)      +46 B  (+0.3%)
async-load-signup-steps-clone-point                                  +274 B  (+0.2%)      +46 B  (+0.1%)
async-load-signup-steps-clone-destination                            +274 B  (+0.8%)      +46 B  (+0.5%)
async-load-signup-steps-clone-credentials                            +274 B  (+0.4%)      +46 B  (+0.2%)
async-load-signup-steps-clone-cloning                                +274 B  (+1.0%)      +46 B  (+0.5%)
async-load-calypso-signup-step-wrapper                               +274 B  (+2.2%)      +46 B  (+1.1%)
async-load-calypso-my-sites-checkout-modal                           +274 B  (+0.0%)      +14 B  (+0.0%)
async-load-calypso-components-jetpack-portal-nav                     +274 B  (+0.6%)      +38 B  (+0.3%)
async-load-calypso-blocks-editor-checkout-modal                      +274 B  (+0.0%)      +14 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug help-center/use-smooch-2 on your sandbox.

@arcangelini
Copy link
Contributor Author

Closing in favor of #94799

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 21, 2024
@arcangelini arcangelini deleted the help-center/use-smooch-2 branch October 15, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants