-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Ability to download backups for expired Atomic sites #94796
base: trunk
Are you sure you want to change the base?
Add: Ability to download backups for expired Atomic sites #94796
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
7e3deee
to
d03158e
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1415 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@villanovachile Thanks for working on this! It looks good overall.
As you mention, it would be nice if we refactor our download process to avoid duplicating code, but I'm fine with proceeding with this PR first, as this is something that will add value to our customers in the short term.
I just left some comments that would be nice to address, so let me know if you have any thoughts. We can also jump into a call if needed.
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@Initsogar I've gone ahead and pushed the changes, but the refresh bug you mentioned also brought to mind another bug that @ash1eygrace found while testing: pdtR3Z-3do-p2#comment-3047:
It looks like this bug is actually present in the production I did some debugging and it appears that although the logic is in place to determine if a download is in progress, once the download finishes, it will automatically return
Again, this really only happens if you click "Create download", then refresh the page, and wait for the download to complete. I was able to resolve this by ordering the if statements as follows (and adding
This way, the order of precedence is renderInProgress > renderReady > renderConfirm. This makes sense to me because it will also ensure that the correct I'd be curious on your thoughts and if you think this is a good approach for correcting this issue as well as implementing this on the |
Related to pIFnH-7g8-p2
Proposed Changes
/backup/{siteSlug}/
page for simple sites that have been reverted and have a valid backup, that will allow users to download the latest valid backup.Why are these changes being made?
Jetpack > Backup
page, so as long as it exists.Testing Instructions
/backup/{siteSlug}/
on a simple site that has never been Atomic - only the upgrade card should appear/backup/{siteSlug}/
on a simple site that was Atomic and has been reverted, and has a valid backup - the download flow should appear under the upgrade card, and should display the date of the backup.Download Screens:
To-do
Add collapsible section if confirmed that this should be added to Jetpack sites as well: pIFnH-7g8-p2#comment-27855download.tsx
component and abstract the header/body content to make it dynamic, while keeping the download functionality itself separate, ensuring that we can removedownload-expired-plan.tsx
, as it duplicates functionality.Pre-merge Checklist