Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add step to show after credential form in platform is other than WP and handle navigation to correct importer #95132

Closed
wants to merge 20 commits into from
Closed

Add step to show after credential form in platform is other than WP and handle navigation to correct importer #95132

wants to merge 20 commits into from

Conversation

gabrielcaires
Copy link
Contributor

Related to #94914

Proposed Changes

  • Add [other-platform-detected-import] step to migration flow
  • Make the step run again. The site analyzes if the platform is not available. It is important to support back behaviors from the importing screens
  • Integrate the step on the migration flow

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Imran92 and others added 20 commits September 28, 2024 04:10
@Imran92
Add mapping functionality for platform check error
c4f220a
@Imran92
Implement URL analyzer check to find hosting
bd313a2
@Imran92
Show loader info when analyzing site URL
304e8f8
@Imran92
Add test to make sure analyzer check and WPCOM error message state works
ce12270
@Imran92
Register the new step page
615b8b3
@Imran92
Add mechanism to forward to importer confirmation page
0c2122c
@Imran92
Add platform in submission if other platform detected
115eb93
@Imran92
Add back button functionality
5dfc716
@Imran92
Enable URL field, check site info on typing
aec11fe
@Imran92
Remove unnecessary param from site address
052839c
@Imran92
Remove unnecessary test
f8c74fa
@Imran92
Remove unnecessary dep
8a77515
@Imran92
Disable only site address button during site info verification
177e368
@gabrielcaires
Rename param to describer better the intent
dee0aea
@gabrielcaires
Remove migration flow references
011e659 
It is causing conflicts because th
@gabrielcaires
Extract site scanning component
eeebb35
@gabrielcaires
Implement platform-detected step
4189270
@gabrielcaires
Integrate with migration step
85e8f8e
@gabrielcaires
Fix missing style
7f747f0
@gabrielcaires
Merge branch 'update/add-platform-verification' into update/add-other…
fe700f6 
…-platform-import-confirmation
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-121158
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-121158&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-121158&env=a8c-for-agencies

@Imran92 Imran92 force-pushed the update/add-platform-verification branch from 96b7003 to d9282b9 Compare October 7, 2024 10:01
@gabrielcaires gabrielcaires changed the title Update/add other platform step Add step to show after credential form in platform is other than WP and handle navigation to correct importer #95019 Oct 7, 2024
@gabrielcaires gabrielcaires changed the title Add step to show after credential form in platform is other than WP and handle navigation to correct importer #95019 Add step to show after credential form in platform is other than WP and handle navigation to correct importe Oct 7, 2024
@gabrielcaires gabrielcaires changed the title Add step to show after credential form in platform is other than WP and handle navigation to correct importe Add step to show after credential form in platform is other than WP and handle navigation to correct importer Oct 7, 2024
Base automatically changed from update/add-platform-verification to trunk October 7, 2024 13:23
@gabrielcaires
Copy link
Contributor Author

I moved to this PR #95246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielcaires @Imran92