Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans (state): Remove getPlanDiscountedRawPrice, getSitePlanRawPrice, isSitePlanDiscounted from Calypso state #95278

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented Oct 10, 2024

Related to #86638

Proposed Changes

Removes each of getPlanDiscountedRawPrice, getSitePlanRawPrice, and isSitePlanDiscounted as obsolete. Plan pricing can be managed through @automattic/data-stores:plans package.

Why are these changes being made?

Reduce state duplication across local Calypso state and the packaged data-stores.

Testing Instructions

  • Build passing
  • Search for name & file references that may go unnoticed, in tests/elsewhere

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

… and isSitePlanDiscounted from Calypso state
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/plans-state-raw-discount-selectors on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@jeyip
Copy link
Contributor

jeyip commented Oct 18, 2024

Testing

Requirements

  • Build passing
  • Did a brief search for isSitePlanDiscounted, getSitePlanRawPrice, and getPlanDiscountedRawPrice. All references in Calypso were removed.
  • Smoke tested pricing on /start/plans

Browsers

  • Chrome

@jeyip jeyip self-requested a review October 18, 2024 18:51
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
@jeyip jeyip marked this pull request as ready for review October 18, 2024 18:52
@jeyip jeyip merged commit c10ac6c into trunk Oct 18, 2024
16 checks passed
@jeyip jeyip deleted the update/plans-state-raw-discount-selectors branch October 18, 2024 19:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants