-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pending sticker when loading the "how to migrate" step #95413
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks very well done! Just for good measure, should we cover this particular behavior with a unit test?
baff4fd
to
7023a65
Compare
Hi @m1r0! It's a bug. Since it's not related to this PR, I just created another issue to handle it: #95560 |
Added some tests here: 970ce0c |
...low/internals/steps-repository/site-migration-how-to-migrate/use-pending-migration-status.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Gabriel Caires <gabriel.caires@automattic.com>
6cef19a
to
4c81714
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Related to #95288
Proposed Changes
Why are these changes being made?
migration-pending
when the user is navigating through the migration flow. See more in p1728684758970459/1728480467.656839-slack-C07N53UNUQJ.Testing Instructions
To check the status creation, you check the network tab of your browser filtering by
/site-migration-status-sticker
. To make sure the status was created, you can check it directly in your sandbox (p1729023356708799/1728480467.656839-slack-C07N53UNUQJ).Test the following steps in
/setup/migration
and in the/setup/hosted-site-migration
:Pre-merge Checklist