Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pending sticker when loading the "how to migrate" step #95413

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Oct 15, 2024

Related to #95288

Proposed Changes

  • Create the sticker when loading the "How to migrate" step.
  • Extract hook to simplify step code.

Why are these changes being made?

  • We want to register the migration-pending when the user is navigating through the migration flow. See more in p1728684758970459/1728480467.656839-slack-C07N53UNUQJ.

Testing Instructions

To check the status creation, you check the network tab of your browser filtering by /site-migration-status-sticker. To make sure the status was created, you can check it directly in your sandbox (p1729023356708799/1728480467.656839-slack-C07N53UNUQJ).

Test the following steps in /setup/migration and in the /setup/hosted-site-migration:

  • Navigate to the "How to migrate" step.
  • Check that it register the pending status.
  • Click on the options, and make sure it continues registering the pending status for the "DIY" and "DIFM".

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@renatho renatho self-assigned this Oct 15, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@renatho renatho marked this pull request as ready for review October 15, 2024 20:17
@renatho renatho requested a review from a team October 15, 2024 20:17
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 15, 2024
@renatho renatho linked an issue Oct 15, 2024 that may be closed by this pull request
@renatho renatho changed the title Create pending sticker when loading the step Create pending sticker when loading the "how to migrate" step Oct 15, 2024
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks very well done! Just for good measure, should we cover this particular behavior with a unit test?

@m1r0
Copy link
Member

m1r0 commented Oct 21, 2024

I'm not sure if it's related to these changes, but when I select "I'll do it myself", I end up with 2 migration stickers:

image

It looks like 2 requests are sent at the same time when the button is clicked. Is this a bug?

@renatho
Copy link
Contributor Author

renatho commented Oct 21, 2024

I'm not sure if it's related to these changes, but when I select "I'll do it myself", I end up with 2 migration stickers:

image

It looks like 2 requests are sent at the same time when the button is clicked. Is this a bug?

Hi @m1r0! It's a bug. Since it's not related to this PR, I just created another issue to handle it: #95560

@renatho
Copy link
Contributor Author

renatho commented Oct 21, 2024

The change looks very well done! Just for good measure, should we cover this particular behavior with a unit test?

Added some tests here: 970ce0c

@renatho renatho requested review from Imran92 and m1r0 October 21, 2024 19:59
Co-authored-by: Gabriel Caires <gabriel.caires@automattic.com>
@renatho renatho force-pushed the add/migration-pending-status branch from 6cef19a to 4c81714 Compare October 23, 2024 14:51
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/migration-pending-status on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post-migration experience: Add pending migration blog sticker
5 participants