Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Onboarding: Implement preview pane and selectable sites #95445

Merged
merged 11 commits into from
Oct 18, 2024

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Oct 16, 2024

Related to https://github.com/Automattic/loop/issues/188

Proposed Changes

  • This PR introduces the preview panel and "highlighted" selectable sites for "step 2"
  • It adds onItemClick and isSelected props to the ConnectedReaderSubscriptionListItem and ReaderSubscriptionListItem components.

Note

This PR does NOT implement a "completed" state when you click the "Continue" button. We'll handle that in a followup PR. It also does NOT implement the "Load more recommendations" feature, but the copy is left in to keep the translations warm.

Before After
Screenshot 2024-10-18 at 9 02 28 AM Screenshot 2024-10-18 at 9 13 53 AM

Why are these changes being made?

  • Push Reader Onboarding forward.

Testing Instructions

  • Use Calypso Live
  • Go to /read?flags=reader/onboarding
  • Ensure you are following 3 or more tags to unlock the "Discover and subscribe to sites you'll love" button.
  • Click "Discover and subscribe to sites you'll love" to view the suggested sites.
  • Click on some suggested sites to see them load in the preview pane.
  • Check for regressions by going to /discover and interact with the sites listed under "Popular sites"
  • Click on all the links and subscribe button in some of the sites under "Popular sites" and ensure they still work as expected.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Oct 16, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~330 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader       +938 B  (+0.1%)     +330 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~88 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks       +217 B  (+0.0%)      +88 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Oct 18, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug try/reader-onboarding-preview on your sandbox.

@DustyReagan DustyReagan self-assigned this Oct 18, 2024
@DustyReagan DustyReagan changed the title Try/reader onboarding preview Reader Onboarding: Implement preview pane and selectable sites Oct 18, 2024
@DustyReagan DustyReagan marked this pull request as ready for review October 18, 2024 14:40
@DustyReagan DustyReagan requested a review from a team as a code owner October 18, 2024 14:40
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Copy link
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress looks great!

@DustyReagan DustyReagan merged commit dcff49b into trunk Oct 18, 2024
14 checks passed
@DustyReagan DustyReagan deleted the try/reader-onboarding-preview branch October 18, 2024 15:30
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants