Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackupScheduleSetting: enable fetching and updating schedule time #95449

Merged
merged 14 commits into from
Oct 18, 2024

Conversation

Initsogar
Copy link
Contributor

@Initsogar Initsogar commented Oct 17, 2024

Related to https://github.com/Automattic/jetpack-backup-team/issues/669

Proposed Changes

Allow users to update their daily backup time schedule. This is still under the jetpack/backup-schedule-setting until we decide to release it.

  • Add useScheduledTimeQuery to handle scheduled time fetch. This one will be reused to display the scheduled time in the Latest backup section as part of https://github.com/Automattic/jetpack-backup-team/issues/700
  • Add useScheduledTimeMutation to handle scheduled time update
  • Enable jetpack/backup-schedule-setting on Jetpack Cloud development and horizon (live branches) environments

Demo

CleanShot.2024-10-18.at.09.06.40.mp4

Why are these changes being made?

https://github.com/Automattic/jetpack-backup-team/issues/669

Testing Instructions

  • Spin up a Jetpack Cloud live branch
  • Pick a site with Jetpack VaultPress Backup plan
  • Navigate to the Settings page
  • You should see the Daily backup time schedule setting at the bottom of the page
  • If you never updated your schedule time, you should see a default one with the Default time message
  • Pick another time slot on the dropdown.
    • The dropdown should be in your local time (the one configured on your site). So if you click 2:00pm (your local time), it will be stored in UTC.
    • When you click it, it will trigger the update (you should see the dropdown being disabled for a bit)
    • Once it completes, you should see a success notice with the message Daily backup time successfully changed.
    • The dropdown should be updated with the new value you selected.
    • The message below the dropdown should be changed to Time set by <user>. UTC: X:XX - X:XX XX.
      • will be the name of the user who performed the action
      • UTC: X:XX - X:XX XX will be the UTC time of the schedule time saved.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Oct 17, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~149 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper              +1267 B  (+0.1%)     +149 B  (+0.0%)
entry-main                 +1267 B  (+0.1%)     +149 B  (+0.0%)
entry-subscriptions         +252 B  (+0.0%)      +84 B  (+0.0%)
entry-login                 +252 B  (+0.0%)      +84 B  (+0.0%)
entry-domains-landing       +252 B  (+0.0%)      +84 B  (+0.0%)
entry-browsehappy           +252 B  (+0.1%)      +84 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~6566 bytes added 📈 [gzipped])

name                           parsed_size            gzip_size
jetpack-cloud-settings            +77479 B  (+12.0%)   +16881 B  (+9.0%)
backup                              +217 B   (+0.0%)     +642 B  (+0.2%)
site-purchases                      +166 B   (+0.0%)    +1121 B  (+0.3%)
purchases                           +166 B   (+0.0%)    +1121 B  (+0.2%)
activity                            +144 B   (+0.0%)     +477 B  (+0.2%)
scan                                -117 B   (-0.0%)     +219 B  (+0.1%)
jetpack-cloud-agency-sites-v2        +93 B   (+0.0%)     +621 B  (+0.1%)
a8c-for-agencies-sites               +93 B   (+0.0%)     +621 B  (+0.1%)
settings                             +48 B   (+0.0%)      -58 B  (-0.0%)
domains                              -30 B   (-0.0%)     +231 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Oct 18, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/backup-schedule-get on your sandbox.

@Initsogar Initsogar added the [Feature] Backups The Jetpack Backup product label Oct 18, 2024
@Initsogar Initsogar marked this pull request as ready for review October 18, 2024 13:59
@Initsogar Initsogar requested a review from a team October 18, 2024 13:59
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Refactor convertHourToRange to consider UTC as a 24-hour format. Also, I’m shifting from building the time range manually, to use moment().
Copy link
Contributor

@mavegaf mavegaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Initsogar Initsogar merged commit 5d25cc3 into trunk Oct 18, 2024
11 checks passed
@Initsogar Initsogar deleted the update/backup-schedule-get branch October 18, 2024 18:16
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
@a8ci18n
Copy link

a8ci18n commented Oct 18, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16927149

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @Initsogar, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Daily backup time successfully changed.
  • Update daily backup time failed. Please, try again.
  • Time set by %(scheduledBy)s
  • Daily backup time schedule

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Oct 21, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Backups The Jetpack Backup product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants