Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Profiler: use fade in and out animation for tips #95473

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

gcsecsey
Copy link
Contributor

@gcsecsey gcsecsey commented Oct 17, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/9108
Follow-up to #95401

Proposed Changes

  • Update the tip update animation

Why are these changes being made?

Testing Instructions

  • Go to /speed-test and start a new test
  • Check that the tips on the loading screen are using a fade in and fade out animation when updated

Before

CleanShot.2024-10-15.at.17.12.39.mp4

After

CleanShot.2024-10-17.at.14.55.05.mp4

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/animate-tips on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~65 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
performance-profiler       -189 B  (-0.1%)      -65 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@gcsecsey gcsecsey marked this pull request as ready for review October 17, 2024 13:57
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this follow-up! I like this more-subtle animation. Changes LGTM! :shipit:


updateCurrentTip();
return () => clearInterval( intervalId );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Copy link
Contributor

@matt-west matt-west left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @gcsecsey

@gcsecsey gcsecsey merged commit c242c5e into trunk Oct 18, 2024
15 checks passed
@gcsecsey gcsecsey deleted the update/animate-tips branch October 18, 2024 11:35
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants