Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchpad: Remove experiment code #95481

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Oct 17, 2024

Related to #93205

Proposed Changes

Why are these changes being made?

  • The experiment ended and we decided the keep the control variant

Testing Instructions

  • go to /setup/site-setup?siteSlug={SITE_SLUG}
  • choose "Promote myself or business"
  • select "Choose a theme"
  • select a theme
  • press "continue" button
  • check if there is a full-screen launchpad

Check any scenario described here: #93205
It should open the full launchpad screen.

NOTE: Some of the flows are not the same anymore

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii requested a review from a team October 17, 2024 16:28
@bogiii bogiii requested a review from a team as a code owner October 17, 2024 16:28
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 17, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 17, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~231 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-stepper              -1246 B  (-0.1%)     -405 B  (-0.1%)
entry-main                  -889 B  (-0.0%)     -351 B  (-0.1%)
entry-login                 -853 B  (-0.0%)     -247 B  (-0.0%)
entry-domains-landing       -853 B  (-0.1%)     -249 B  (-0.1%)
entry-browsehappy           -853 B  (-0.4%)     -249 B  (-0.4%)
entry-subscriptions         -785 B  (-0.0%)      -75 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~11226 bytes removed 📉 [gzipped])

name                                parsed_size            gzip_size
site-setup-wg                           -7917 B   (-8.4%)    -2970 B  (-15.1%)
site-setup-flow                         -7917 B   (-8.5%)    -2970 B  (-15.7%)
free-flow                               -7816 B  (-11.0%)    -2931 B  (-23.9%)
start-writing-flow                      -7358 B  (-23.0%)    -2893 B  (-33.1%)
newsletter-flow                         -7358 B  (-26.3%)    -2890 B  (-34.3%)
design-first-flow                       -7358 B  (-22.5%)    -2874 B  (-32.6%)
build-flow                              -7276 B   (-0.9%)    -2832 B   (-1.2%)
home                                    -6844 B   (-0.4%)    -2186 B   (-0.5%)
update-design-flow                      -1912 B   (-0.2%)     -772 B   (-0.2%)
signup                                   -824 B   (-0.3%)      -70 B   (-0.1%)
link-in-bio-tld-flow                     -721 B   (-0.0%)     -327 B   (-0.1%)
with-theme-assembler-flow                -540 B   (-0.8%)      -53 B   (-0.5%)
update-options-flow                      -540 B   (-1.0%)      -54 B   (-0.9%)
trial-wooexpress-flow                    -540 B   (-1.0%)      -59 B   (-0.8%)
tailored-ecommerce-flow                  -540 B   (-0.9%)      -51 B   (-0.7%)
site-migration-flow                      -540 B   (-0.8%)      -55 B   (-0.6%)
readymade-template-flow                  -540 B   (-0.4%)      -47 B   (-0.2%)
migration-signup                         -540 B   (-0.9%)      -53 B   (-0.7%)
migration-flow                           -540 B   (-0.7%)      -55 B   (-0.4%)
import-flow                              -540 B   (-0.8%)      -53 B   (-0.5%)
hosted-site-migration-flow               -540 B   (-0.8%)      -54 B   (-0.5%)
free-post-setup-flow                     -540 B   (-1.0%)      -51 B   (-0.9%)
entrepreneur-flow                        -540 B   (-0.4%)      -58 B   (-0.2%)
assembler-first-flow                     -540 B   (-0.7%)      -51 B   (-0.4%)
ai-assembler-flow                        -540 B   (-0.7%)      -52 B   (-0.4%)
migrate                                  -196 B   (-0.1%)     -349 B   (-0.3%)
jetpack-app                              -196 B   (-0.0%)     -880 B   (-0.7%)
import-hosted-site-flow                  -196 B   (-0.0%)     -601 B   (-0.2%)
stats                                    -165 B   (-0.0%)     -102 B   (-0.0%)
link-in-bio-flow                         -109 B   (-0.6%)      -43 B   (-0.8%)
reblogging-flow                          -108 B   (-1.8%)      -43 B   (-2.3%)
onboarding-flow                          -108 B   (-0.6%)      -48 B   (-0.8%)
new-hosted-site-flow-user-included       -108 B   (-1.8%)      -45 B   (-2.2%)
new-hosted-site-flow                     -108 B   (-1.8%)      -46 B   (-2.2%)
connect-domain                           -108 B   (-0.4%)      -47 B   (-0.7%)
staging-site                              -65 B   (-0.0%)       +7 B   (+0.0%)
hosting                                   -65 B   (-0.0%)     -365 B   (-0.1%)
earn                                      -62 B   (-0.0%)      -43 B   (-0.0%)
reader                                    +34 B   (+0.0%)     +170 B   (+0.1%)
plugins                                   +34 B   (+0.0%)     -165 B   (-0.0%)
jetpack-cloud-plugin-management           +34 B   (+0.0%)     +273 B   (+0.0%)
subscribers                               -28 B   (-0.0%)     +236 B   (+0.1%)
site-performance                          +13 B   (+0.0%)       +8 B   (+0.0%)
site-monitoring                           +13 B   (+0.0%)      +11 B   (+0.0%)
site-logs                                 +13 B   (+0.0%)      +11 B   (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~821 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected       -196 B  (-0.0%)     -821 B  (-0.6%)
async-load-signup-steps-plans                         -196 B  (-0.0%)     -821 B  (-0.6%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ouikhuan ouikhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some flow has changing the behavior now, I tried my best to test all of it and here's the result for each flow:

BUILD flow

Scenario 1: ✅
Scenario 2: There's no WP icon button to press anymore, can't test.
Scenario 3: ❌ Shows me the custom home, see video below. ( it looks like it's not consistent, if you pick a theme that you haven't used before, it always go to custom home, but if you pick one from previous used, you'll be able to see the full screen launchpad sometimes.

build-flow-scenario-3.mov

DESIGN FIRST flow: ❌ Shows me the custom home.
START WRITING flow: Didn't get to see the "Next Steps" button so not able to check.
NEWSLETTER flow: ❌ Shows me the custom home. Please see video below for more details.

newsletter-flow.mov

WRITE flow: ✅ It shows a different modal in the end now, so not able to hover over and check the URL, but it does redirect me to the launchpad.

FREE flow: Looks like the behavior of the free flow has completely changed now? After I type in the domain it always brings me to the goals screen.

Please let me know if you have any questions about the descriptions/videos above, happy to walkthrough it together!

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/launchpad-experiment-remove on your sandbox.

@bogiii bogiii requested a review from ouikhuan October 18, 2024 14:15
@bogiii
Copy link
Contributor Author

bogiii commented Oct 18, 2024

I've updated the flag value, which needed to be corrected. It was a leftover from the testing/development phase.
Sorry about that.

Keep in mind that some of the flow has been changed and is not the same as it used to be before the disabling launchpad effort.

Also, we don't need to do anything on the Jetpack side since the Popover feature has been removed in the meantime.

Copy link
Contributor

@ouikhuan ouikhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now, thanks! 🚢

@bogiii bogiii merged commit 8a8f665 into trunk Oct 18, 2024
13 checks passed
@bogiii bogiii deleted the update/launchpad-experiment-remove branch October 18, 2024 15:48
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants