-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launchpad: Remove experiment code #95481
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~231 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~11226 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~821 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some flow has changing the behavior now, I tried my best to test all of it and here's the result for each flow:
BUILD flow
Scenario 1: ✅
Scenario 2: There's no WP icon button to press anymore, can't test.
Scenario 3: ❌ Shows me the custom home, see video below. ( it looks like it's not consistent, if you pick a theme that you haven't used before, it always go to custom home, but if you pick one from previous used, you'll be able to see the full screen launchpad sometimes.
build-flow-scenario-3.mov
DESIGN FIRST flow: ❌ Shows me the custom home.
START WRITING flow: Didn't get to see the "Next Steps" button so not able to check.
NEWSLETTER flow: ❌ Shows me the custom home. Please see video below for more details.
newsletter-flow.mov
WRITE flow: ✅ It shows a different modal in the end now, so not able to hover over and check the URL, but it does redirect me to the launchpad.
FREE flow: Looks like the behavior of the free flow has completely changed now? After I type in the domain it always brings me to the goals screen.
Please let me know if you have any questions about the descriptions/videos above, happy to walkthrough it together!
client/landing/stepper/declarative-flow/internals/hooks/use-launchpad-decider/index.tsx
Outdated
Show resolved
Hide resolved
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
I've updated the flag value, which needed to be corrected. It was a leftover from the testing/development phase. Keep in mind that some of the flow has been changed and is not the same as it used to be before the disabling launchpad effort. Also, we don't need to do anything on the Jetpack side since the Popover feature has been removed in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now, thanks! 🚢
Related to #93205
Proposed Changes
Why are these changes being made?
Testing Instructions
/setup/site-setup?siteSlug={SITE_SLUG}
Check any scenario described here: #93205
It should open the full launchpad screen.
NOTE: Some of the flows are not the same anymore
Pre-merge Checklist