Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: Add queue possibility to record signup completion #95482

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

escapemanuele
Copy link
Contributor

@escapemanuele escapemanuele commented Oct 17, 2024

p1729151031413209-slack-C073776NJ66

Proposed Changes

Let the recordSignupComplete function have the possibility of being added to a queue, as it happens in Start.

Why are these changes being made?

There are discrepancies in the firing of calypso_signup_complete and calypso_new_user_site_creation between Stepper and Start in the ongoing experiment.

Testing Instructions

  • Live link
  • Go through /setup/onboarding
  • Verify that all the events get triggered correctly, like when you go through /start

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@escapemanuele escapemanuele self-assigned this Oct 17, 2024
@escapemanuele escapemanuele requested a review from a team October 17, 2024 17:04
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 17, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug stepper-queue-signup-complete on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@escapemanuele escapemanuele merged commit 5fed8dd into trunk Oct 17, 2024
15 checks passed
@escapemanuele escapemanuele deleted the stepper-queue-signup-complete branch October 17, 2024 17:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants