Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Domains: Create 100-Year Domain flow" #95486

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

leonardost
Copy link
Contributor

@leonardost leonardost commented Oct 17, 2024

Reverts #95081

Creating this just in case something breaks 🤞 will close this after a while if everything seems ok.

@leonardost leonardost requested review from a team as code owners October 17, 2024 19:36
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 17, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert-95081-add/hundred-year-domain-flow on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~280 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               -573 B  (-0.0%)     -106 B  (-0.0%)
entry-main                  -439 B  (-0.0%)      -78 B  (-0.0%)
entry-subscriptions         -381 B  (-0.0%)     -269 B  (-0.1%)
entry-login                 -313 B  (-0.0%)      -95 B  (-0.0%)
entry-domains-landing       -313 B  (-0.0%)      -95 B  (-0.0%)
entry-browsehappy           -313 B  (-0.2%)      -95 B  (-0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~6684 bytes added 📈 [gzipped])

name                               parsed_size             gzip_size
hundred-year-domain                   -49327 B  (deleted)   -14811 B  (deleted)
update-design-flow                     -1489 B    (-0.1%)     -295 B    (-0.1%)
link-in-bio-tld-flow                   -1396 B    (-0.1%)     -305 B    (-0.1%)
copy-site-flow                         -1082 B    (-0.2%)     -401 B    (-0.2%)
domains                                 -751 B    (-0.0%)     -120 B    (-0.0%)
videopress-flow                         -589 B    (-0.1%)     -318 B    (-0.1%)
signup                                  -514 B    (-0.2%)      -43 B    (-0.1%)
sensei-flow                             -496 B    (-0.1%)     +509 B    (+0.3%)
account                                 -298 B    (-0.0%)     -356 B    (-0.1%)
start-writing-flow                      -216 B    (-0.7%)      -31 B    (-0.4%)
onboarding-flow                         -216 B    (-1.2%)      -25 B    (-0.4%)
design-first-flow                       -216 B    (-0.7%)      -29 B    (-0.3%)
site-purchases                          -205 B    (-0.0%)      -53 B    (-0.0%)
marketplace                             -142 B    (-0.0%)      -62 B    (-0.0%)
plugins                                 -136 B    (-0.0%)     -173 B    (-0.0%)
home                                    -136 B    (-0.0%)     -297 B    (-0.1%)
videopress-tv-flow                      -128 B    (-0.2%)     +502 B    (+2.0%)
hosting                                 -115 B    (-0.0%)      -35 B    (-0.0%)
with-theme-assembler-flow               -108 B    (-0.2%)      -11 B    (-0.1%)
update-options-flow                     -108 B    (-0.2%)      -11 B    (-0.2%)
trial-wooexpress-flow                   -108 B    (-0.2%)       -9 B    (-0.1%)
tailored-ecommerce-flow                 -108 B    (-0.2%)      -12 B    (-0.2%)
site-setup-wg                           -108 B    (-0.1%)      -15 B    (-0.1%)
site-setup-flow                         -108 B    (-0.1%)      -15 B    (-0.1%)
site-migration-flow                     -108 B    (-0.2%)      -10 B    (-0.1%)
reblogging-flow                         -108 B    (-1.8%)      -23 B    (-1.2%)
readymade-template-flow                 -108 B    (-0.1%)      -12 B    (-0.0%)
newsletter-flow                         -108 B    (-0.4%)      -25 B    (-0.3%)
migration-signup                        -108 B    (-0.2%)      -12 B    (-0.2%)
migration-flow                          -108 B    (-0.1%)      -11 B    (-0.1%)
link-in-bio-flow                        -108 B    (-0.6%)      -24 B    (-0.5%)
import-flow                             -108 B    (-0.2%)      -11 B    (-0.1%)
hundred-year-plan                       -108 B    (-0.3%)      -14 B    (-0.1%)
hosted-site-migration-flow              -108 B    (-0.2%)      -10 B    (-0.1%)
google-transfer                         -108 B    (-2.5%)       -3 B    (-0.2%)
free-post-setup-flow                    -108 B    (-0.2%)      -11 B    (-0.2%)
free-flow                               -108 B    (-0.2%)      -10 B    (-0.1%)
entrepreneur-flow                       -108 B    (-0.1%)       -9 B    (-0.0%)
domain-transfer                         -108 B    (-2.7%)       -4 B    (-0.3%)
assembler-first-flow                    -108 B    (-0.1%)      -11 B    (-0.1%)
ai-assembler-flow                       -108 B    (-0.1%)      -11 B    (-0.1%)
settings-security                       -103 B    (-0.0%)      -10 B    (-0.0%)
people                                  -103 B    (-0.0%)      -12 B    (-0.0%)
newsletter-post-setup-flow              -103 B    (-0.1%)      -24 B    (-0.1%)
link-in-bio-post-setup-flow             -103 B    (-0.1%)      -24 B    (-0.1%)
domain-user-transfer-flow               -103 B    (-0.0%)      -19 B    (-0.0%)
themes                                  -102 B    (-0.0%)      -44 B    (-0.0%)
theme                                   -102 B    (-0.0%)      -44 B    (-0.0%)
site-blocks                             -102 B    (-0.0%)      -37 B    (-0.0%)
settings                                -102 B    (-0.0%)      -40 B    (-0.0%)
security                                -102 B    (-0.0%)      -98 B    (-0.0%)
purchases                               -102 B    (-0.0%)      -40 B    (-0.0%)
privacy                                 -102 B    (-0.0%)      -37 B    (-0.0%)
plans                                   -102 B    (-0.0%)      -93 B    (-0.0%)
notification-settings                   -102 B    (-0.0%)      -35 B    (-0.0%)
me                                      -102 B    (-0.0%)      -37 B    (-0.0%)
jetpack-connect                         -102 B    (-0.0%)     -170 B    (-0.1%)
jetpack-cloud-settings                  -102 B    (-0.0%)      -37 B    (-0.0%)
jetpack-cloud-pricing                   -102 B    (-0.0%)     -197 B    (-0.1%)
jetpack-cloud-features-comparison       -102 B    (-0.0%)     -133 B    (-0.1%)
jetpack-app                             -102 B    (-0.0%)      +38 B    (+0.0%)
help                                    -102 B    (-0.0%)      -37 B    (-0.0%)
email                                   -102 B    (-0.0%)      -38 B    (-0.0%)
developer                               -102 B    (-0.0%)      -37 B    (-0.0%)
checkout                                -102 B    (-0.0%)      -61 B    (-0.0%)
account-close                           -102 B    (-0.0%)      -37 B    (-0.0%)
staging-site                             -87 B    (-0.0%)       +8 B    (+0.0%)
sites-dashboard                          -74 B    (-0.0%)      -21 B    (-0.0%)
site-performance                         -74 B    (-0.0%)      -21 B    (-0.0%)
site-monitoring                          -74 B    (-0.0%)      -21 B    (-0.0%)
site-logs                                -74 B    (-0.0%)      -21 B    (-0.0%)
hosting-features                         -74 B    (-0.0%)      -21 B    (-0.0%)
github-deployments                       -74 B    (-0.0%)      -21 B    (-0.0%)
stats                                    -69 B    (-0.0%)     -342 B    (-0.1%)
earn                                     +62 B    (+0.0%)      +45 B    (+0.0%)
reader                                   -34 B    (-0.0%)     -170 B    (-0.1%)
jetpack-cloud-plugin-management          -34 B    (-0.0%)     -291 B    (-0.0%)
subscribers                              +28 B    (+0.0%)     -236 B    (-0.1%)
connect-domain                           -28 B    (-0.1%)      -19 B    (-0.3%)
write-flow                               -15 B    (-0.0%)       -7 B    (-0.0%)
transferring-hosted-site-flow            -15 B    (-0.0%)       -7 B    (-0.0%)
plugin-bundle-flow                       -15 B    (-0.0%)       -7 B    (-0.0%)
import-hosted-site-flow                  -15 B    (-0.0%)       -6 B    (-0.0%)
build-flow                               -15 B    (-0.0%)       -6 B    (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~523 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-domains                                                        -649 B  (-0.1%)     -258 B  (-0.2%)
async-load-design-blocks                                                               -142 B  (-0.0%)      -51 B  (-0.0%)
async-load-signup-steps-site-options                                                   -103 B  (-0.2%)      -27 B  (-0.2%)
async-load-signup-steps-rewind-form-creds                                              -103 B  (-0.1%)      -40 B  (-0.2%)
async-load-signup-steps-clone-credentials                                              -103 B  (-0.1%)      -40 B  (-0.2%)
async-load-design-playground                                                           -103 B  (-0.0%)      -23 B  (-0.0%)
async-load-design                                                                      -103 B  (-0.0%)      -23 B  (-0.0%)
async-load-purchase-modal-wrapper                                                      -102 B  (-0.0%)      -38 B  (-0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...       -102 B  (-0.0%)      -38 B  (-0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice                       -102 B  (-0.4%)      -38 B  (-0.6%)
async-load-calypso-blocks-editor-checkout-modal                                        -102 B  (-0.0%)      -37 B  (-0.0%)
async-load-calypso-layout-masterbar-checkout                                            -74 B  (-0.1%)      -24 B  (-0.1%)
async-load-calypso-my-sites-checkout-modal                                              -28 B  (-0.0%)      -17 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants