Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manual curation for creative category #95499

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

davemart-in
Copy link
Contributor

Description

@DustyReagan this is ready for review. Please feel free to merge this if it looks good. Thanks!

@davemart-in davemart-in self-assigned this Oct 17, 2024
@davemart-in davemart-in requested a review from a team as a code owner October 17, 2024 20:57
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 17, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 17, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/reader-creative-curated-blogs on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Oct 17, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2241 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader      +5436 B  (+0.5%)    +2241 B  (+0.7%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for putting these together, Dave!

@DustyReagan DustyReagan merged commit b36be24 into trunk Oct 18, 2024
11 checks passed
@DustyReagan DustyReagan deleted the add/reader-creative-curated-blogs branch October 18, 2024 16:02
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants