Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Add "New" badge to Bluesky #95508

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

manzoorwanijk
Copy link
Member

Related to #

Proposed Changes

  • Add "New" badge to Bluesky
  • Remove "New" badge from Threads

Why are these changes being made?

Testing Instructions

  • Goto /marketing/connections/:site
  • Confirm that you see the "New" badge for Bluesky
  • Confirm that Threads no longer has the "New" badge

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?
Before After
Screenshot 2024-10-18 at 10 52 48 AM Screenshot 2024-10-18 at 10 53 48 AM

@manzoorwanijk manzoorwanijk requested a review from a team October 18, 2024 05:28
@manzoorwanijk manzoorwanijk self-assigned this Oct 18, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 18, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/new-badge-for-bluesky on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@manzoorwanijk manzoorwanijk merged commit 275f909 into trunk Oct 18, 2024
14 checks passed
@manzoorwanijk manzoorwanijk deleted the update/new-badge-for-bluesky branch October 18, 2024 08:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants