-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Clean up tooltip delay logic #95509
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~23 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~10 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
51fbcea
to
9b31c84
Compare
Related to:
Proposed Changes
Updates the logic checking for new sites to properly handle a
null
value fromgetSiteOption()
. In this way, the tooltip is not addressed until the timestamp is available.Refactors the code to encapsulate the necessary checks and clarify the intent.
Why are these changes being made?
Keeps the additional state setup together instead of doing some setup in the
connect()
function and then needing additional checks for validity inside the component.Testing Instructions
See steps in: #95466
To force the bug condition you'll need to build locally, force the
showSettingsTooltip
totrue
, and set thesiteCreatedTimeStamp
to a value representing a date less than one week old. With those conditions in place, reload the Traffic page a few times and confirm the tooltip is never flashed on screen temporarily.Pre-merge Checklist