Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: Fix how isNewAccount is calculated #95510

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

escapemanuele
Copy link
Contributor

@escapemanuele escapemanuele commented Oct 18, 2024

Proposed Changes

Change how isNewAccountCreated is calculated in Stepper during account creation. This makes it similar to how Start calculates it.
It will later be used, upon signup flow completion, to trigger calypso_new_user_site_creation.

Why are these changes being made?

There is a big discrepancy in the calypso_new_user_site_creation event, with Stepper logging a really low number.

Testing Instructions

  • Live link
  • Go through the onboarding flow in Stepper and in Start and check that both have the same events triggered.
  • Check for calypso_new_user_site_creation and calypso_signup_complete

@escapemanuele escapemanuele changed the title Fix isNewaccount Stepper: Fix how isNewAccount is calculated Oct 18, 2024
@escapemanuele escapemanuele requested a review from a team October 18, 2024 09:02
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
@escapemanuele escapemanuele self-assigned this Oct 18, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@renancarvalho
Copy link
Contributor

Comparing side by side calypso_signup_complete I can see that is_new_site property is being logged correctly or at least equally.

start

  • blog_id: 238150157 Blog RC
  • blog_lang: en
  • client: browser
  • elapsed_time_since_start: 35099
  • environment: production
  • environment_id: wpcalypso
  • flow: onboarding
  • framework: start
  • has_cart_items: true
  • is_blank_canvas: false
  • is_new_site: true
  • is_new_user: false
  • plan_product_slug: personal-bundle
  • signup_domain_origin: free
  • site_count: 186
  • site_id_label: wpcom
  • site_plan_id: 1
  • user_lang: en
  • vph: 1006
  • vpw: 2047

setup

  • blog_id: 238150234 Blog RC
  • client: browser
  • elapsed_time_since_start: 182776
  • environment: production
  • environment_id: wpcalypso
  • flow: onboarding
  • framework: stepper
  • has_cart_items: true
  • intent: onboarding
  • is_blank_canvas: false
  • is_new_site: true
  • is_new_user: false
  • plan_product_slug: personal-bundle
  • signup_domain_origin: free
  • site_count: 185
  • site_id_label: wpcom
  • starting_point: onboarding
  • theme:
  • user_lang: en
  • vph: 1006

I was unable to see calypso_new_user_site_creation event in both start and setup.

@escapemanuele escapemanuele merged commit 4fd6ada into trunk Oct 18, 2024
11 checks passed
@escapemanuele escapemanuele deleted the stepper-fix-newuser branch October 18, 2024 15:48
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants