Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans: update "Limited time offer" to "Special offer" #95522

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

michaeldcain
Copy link
Member

@michaeldcain michaeldcain commented Oct 18, 2024

When we switched the local currency discounts to use introductory offers in #86434, we consolidated the logic for the offer pill to use the same "Limited time offer" text as the Woo Express plans that were already utilizing introductory offers. @niranjan-uma-shankar then pointed out that since these promotions are longer-running, we shouldn't use the "limited time" wording (p58i-fkS-p2#comment-64883).

This PR update the text to use the wording "Special offer", which falls within the constraint of "unique to our normal business offerings". I understand that the original wording was "One time discount", but since this is the fallback wording for all introductory offers, "Special offer" felt more applicable. We can add conditions to use "One time discount" for these specific offers in a follow-up if it's needed.

Screenshot 2024-10-18 at 11 33 26 AM

To test:

  • For the INR, PHP, or MXN currencies, on a site that hasn't previously had a plan purchase:
  • Visit Upgrades > Plans
  • Verify that the introductory offer pill says "Special offer"

@michaeldcain michaeldcain self-assigned this Oct 18, 2024
@michaeldcain michaeldcain requested a review from a team as a code owner October 18, 2024 15:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
@michaeldcain michaeldcain requested a review from a team October 18, 2024 15:32
@michaeldcain michaeldcain added the [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. label Oct 18, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@aneeshd16 aneeshd16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Since the string is not translated, can we add a fallback using useHasEnTranslation? Or maybe add the "String Freeze" label if the change is not urgent?

@michaeldcain michaeldcain added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 19, 2024
@a8ci18n
Copy link

a8ci18n commented Oct 19, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16928151

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @michaeldcain for including a screenshot in the description! This is really helpful for our translators.

@southp
Copy link
Contributor

southp commented Oct 21, 2024

@michaelpick once clarified about the usage of title casing here: pau2Xa-5Sh-p2#comment-15417

We avoid the use of title casing on LPs and UX surfaces for anything that isn’t a ‘name branded’ feature, plan name, or the title headline of a page.

Thus, I'm wondering if we should use this opportunity to update the capitalization as well, to "Special offer" instead 🤔
@michaelpick could you help us confirm? I'd be grateful :)

@michaelpick
Copy link
Contributor

Thus, I'm wondering if we should use this opportunity to update the capitalization as well, to "Special offer" instead 🤔
@michaelpick could you help us confirm? I'd be grateful :)

Hey @southp! I'm not sure we've ever settled on a style rule for labels, but looking at the 'Best for' labels at the top of the same grid they appear to be sentence case, so I'd say consistency would be a good call here.

@michaeldcain
Copy link
Member Author

@southp thanks for the suggestion. Since the new string is 81% translated, I might go ahead and merge this and then follow-up with a change to the casing. I'm pretty sure the translation will get picked up by our fuzzy matching, but don't want to queue a retranslation at this time.

Copy link
Contributor

@jjchrisdiehl jjchrisdiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 21, 2024
@a8ci18n
Copy link

a8ci18n commented Oct 22, 2024

Translation for this Pull Request has now been finished.

@michaeldcain michaeldcain merged commit e7824ef into trunk Oct 22, 2024
18 of 20 checks passed
@michaeldcain michaeldcain deleted the update/plans-pill-offer-text branch October 22, 2024 15:30
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants