Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start: Domains, do not submit when removing the free domain #95523

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

escapemanuele
Copy link
Contributor

Context: p1729251522419809-slack-C073776NJ66

Proposed Changes

Avoid submitting the Domains step when removing the free domain.

Why are these changes being made?

Removing the free domain shouldn't trigger the step submission

Testing Instructions

  • Go to /start and in the domains step add and remove the free domain
  • Check that calypso_signup_actions_submit_step (step: domains) is not triggered.
  • Check that it triggered when actually submitting the step

@escapemanuele escapemanuele requested a review from a team as a code owner October 18, 2024 16:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
@escapemanuele escapemanuele changed the title Do not submit when removing the free domain Start: Domains, do not submit when removing the free domain Oct 18, 2024
@escapemanuele escapemanuele requested review from skim1220 and a team October 18, 2024 16:47
@escapemanuele escapemanuele self-assigned this Oct 18, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~15 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains       -103 B  (-0.0%)      -15 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@skim1220
Copy link

@escapemanuele, I just ran a quick test with the classic flow and can confirm that calypso_signup_actions_submit_step (step: domains) is no longer triggered when a selected free domain is removed 🎉

@escapemanuele escapemanuele merged commit 1cd82c8 into trunk Oct 23, 2024
17 checks passed
@escapemanuele escapemanuele deleted the start-no-submit-free-removal branch October 23, 2024 15:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants