Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites Dashboard: Layout improvements #95536

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

taipeicoder
Copy link
Contributor

Related to p1729282075333529-slack-C048CUFRGFQ

Proposed Changes

This PR proposed some quick layout improvements to the sites dashboard.

Before:
SCR-20241020-jrcr

After:
SCR-20241020-jwyd

Not in scope:

  • Optimizing alignment when scrollbar is always being shown.
  • Making the table full-width for wide resolutions.

Why are these changes being made?

Contributes to the overall polish of WordPress.com

Testing Instructions

  • Head to /sites
  • Ensure that alignments are updated as shown above.
  • Also test different resolutions and alignments still make sense.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/sites-dashboard-layout on your sandbox.

@taipeicoder taipeicoder requested a review from a team October 20, 2024 03:05
@taipeicoder taipeicoder self-assigned this Oct 20, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 20, 2024
@taipeicoder taipeicoder added Lego Maintenance and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 20, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 20, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@taipeicoder taipeicoder merged commit 5d249a4 into trunk Oct 21, 2024
13 of 16 checks passed
@taipeicoder taipeicoder deleted the update/sites-dashboard-layout branch October 21, 2024 02:37
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 21, 2024
@nuriapenya
Copy link

@taipeicoder @lucasmendes-design perhaps we should consider removing the max-width on the wrapper, to make sure everything extends within the flyout. Like it's done on the other usages of DataView component:

Editor:
screen 2024-10-22 at 15 52 59

A4A:
screen 2024-10-22 at 15 51 35

My suggestion for Plugins/manage:
screen 2024-10-22 at 15 51 53

Thoughts?

@taipeicoder
Copy link
Contributor Author

Yes I would prefer to keep them consistent by removing the max-width, @lucasmendes-design WDYT?
cc: @arthur791004 as per this message p1729751192440159-slack-C06DN6QQVAQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants