-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sticky state for the plans grid action buttons #95537
base: trunk
Are you sure you want to change the base?
Conversation
Link to live branch is being generated... |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
The ticket raises an additional issue, however I haven't been able to replicate:
I've added a comment to the ticket. If you're able to reproduce this behaviour, let me know! Update: I was able to replicate the issue in Firefox and have pushed a fix: #82853 (comment) |
Translation for this Pull Request has now been finished. |
@southp Thanks for the review!
Good idea, updated to use the dot: fcdffc9
Yes you're right, there is quite a bit of room. I've created a ticket: https://github.com/Automattic/martech/issues/3504 I've also pushed a fix to prevent the sticky behaviour at the bottom of the screen: 9549718 |
Just noticed we have separate action button strings for the |
05b3a5d
to
9b5482b
Compare
…in intersectionRect.bottom
9b5482b
to
1f0d0e3
Compare
Related to #82853
Proposed Changes
Why are these changes being made?
Testing Instructions
/plans/:site
Pre-merge Checklist