-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Settings: Use an info notices when changing the admin style and global edge cache #95546
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~31 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~18 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is all good, but one observation! I’m not sure it really makes sense to use an infoNotice
for a busy
state here. From what I can tell, it looks like Calypso favours plainNotice
for this sort of thing. For example, the login screen uses plainNotice
when sending an SMS etc.
(I know that there might be a reason for this change though - just a slight observation that it might be good to harmonise the use cases here)
Thanks for the feedback @Aurorum. We’d like to update these notices to use the info state so that they’re more visible to the user. We use blue elsewhere to convey progress (progress bars, spinners, etc.) so it makes sense to bring that consistency to these notices. I’ll run through and see which other notices need updating. Looking again at the dev docs, I discovered that the Screen.Recording.2024-10-21.at.15.05.43.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Nice initiative. The loading state is a great touch.
I'm not concerned about a convention around plainNotice
or infoNotice
. The difference is all styling anyway. Thanks for the review, though, @Aurorum!
Fixes https://github.com/Automattic/dotcom-forge/issues/9472
Proposed Changes
infoNotice
in a loading state when changing the admin style or toggle global edge cache.Before:
After:
Screen.Recording.2024-10-21.at.15.05.43.mov
Why are these changes being made?
Testing Instructions
Admin style
Global edge cache