-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A > Agency Tier: Implement tier permission check #95547
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
@@ -15,6 +18,7 @@ export default function () { | |||
`${ A4A_PARTNER_DIRECTORY_LINK }/:section?`, | |||
requireAccessContext, | |||
partnerDirectoryDashboardContext, | |||
requireTierAccessContext, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are mainly replacing the context's primary content with the error content.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~99 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~13535 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks, @yashwin .
One request: Can you add text-wrap: balance;
to the headline?
It will make it a bit nicer:
Thanks for the review, @madebynoam! I noticed a while back and was fixing the same :D |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected.
LGTM!
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16939669 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators. |
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1303
Proposed Changes
This PR implements a tier permission check, allowing users to view the page only if it is accessible.
Note: MC tool links are in the issue mentioned above.
Testing Instructions
Learn more
button should take you to /agency-tier. Verify it looks good on mobile views, too. Screenshots at the bottom.Update your agency tier to Emerging Partner using the MC tool > Refresh the UI and verify that the permissions error is displayed as shown above.
Change the agency tier to Agency Partner > Refresh the UI and verify that the permissions error is no longer showing and that you can view the Partner Directory.
Change the agency tier to Pro Agency Partner > Refresh the UI and verify that the permissions error is no longer showing and that you can view the Partner Directory.
Small screens:
Pre-merge Checklist