Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Creation: adds partnerBundle to the options. #95551

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

cpapazoglou
Copy link
Contributor

@cpapazoglou cpapazoglou commented Oct 21, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/9480

Proposed Changes

  • For any stepper flow, captures partnerBundle from the query parameter
  • Passes it to the site creation api call

Testing Instructions

  • Navigate to /setup/new-hosted-site?partnerBundle=myNewShinyBundle
  • Check the created site options for site_partner_bundle === myNewShinyBundle by running in wpsh gpr select * from wp_BLOGID_options where option_name = 'site_partner_bundle';

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@cpapazoglou cpapazoglou self-assigned this Oct 21, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 21, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~27 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +53 B  (+0.0%)      +27 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~218 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
entrepreneur-flow             -102 B  (-0.1%)      -56 B  (-0.2%)
link-in-bio-tld-flow           +66 B  (+0.0%)      +26 B  (+0.0%)
import-hosted-site-flow        +66 B  (+0.0%)      +30 B  (+0.0%)
copy-site-flow                 +66 B  (+0.0%)      +32 B  (+0.0%)
write-flow                     +64 B  (+0.0%)      +25 B  (+0.0%)
videopress-flow                +64 B  (+0.0%)      +25 B  (+0.0%)
update-design-flow             +64 B  (+0.0%)      +28 B  (+0.0%)
staging-site                   +64 B  (+0.0%)      +28 B  (+0.0%)
sites-dashboard                +64 B  (+0.0%)      +28 B  (+0.0%)
site-performance               +64 B  (+0.0%)      +28 B  (+0.0%)
site-monitoring                +64 B  (+0.0%)      +28 B  (+0.0%)
site-logs                      +64 B  (+0.0%)      +28 B  (+0.0%)
settings                       +64 B  (+0.0%)      +25 B  (+0.0%)
sensei-flow                    +64 B  (+0.0%)      +27 B  (+0.0%)
hundred-year-plan              +64 B  (+0.2%)      +27 B  (+0.3%)
hundred-year-domain            +64 B  (+0.1%)      +27 B  (+0.2%)
hosting-features               +64 B  (+0.0%)      +28 B  (+0.0%)
hosting                        +64 B  (+0.0%)      +28 B  (+0.0%)
home                           +64 B  (+0.0%)      +24 B  (+0.0%)
github-deployments             +64 B  (+0.0%)      +28 B  (+0.0%)
build-flow                     +64 B  (+0.0%)      +25 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@cpapazoglou
Copy link
Contributor Author

cpapazoglou commented Oct 22, 2024

Deployed r307024-wpcom that handles the site_partner_bundle in the backend and r307031-wpcom that makes sure it's preserved after the atomic transfer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants