Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailored Flows: Remove /setup/blog flow #95555

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Tailored Flows: Remove /setup/blog flow #95555

merged 3 commits into from
Oct 24, 2024

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Oct 21, 2024

Part of https://github.com/Automattic/dotcom-forge/issues/9333

Proposed Changes

Removes the code associated to the /setup/blog tailored blow since we no longer use it.

Why are these changes being made?

To clean up unused code.

Testing Instructions

  • Go to /setup/blog
  • Make sure it still redirects to /start

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mmtr mmtr requested a review from a team October 21, 2024 15:10
@mmtr mmtr requested a review from a team as a code owner October 21, 2024 15:11
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 21, 2024
@mmtr mmtr self-assigned this Oct 21, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 21, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~170 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               -467 B  (-0.0%)     -170 B  (-0.0%)
entry-subscriptions         -385 B  (-0.0%)     -154 B  (-0.0%)
entry-main                  -385 B  (-0.0%)     -154 B  (-0.0%)
entry-login                 -385 B  (-0.0%)     -154 B  (-0.0%)
entry-domains-landing       -385 B  (-0.1%)     -154 B  (-0.1%)
entry-browsehappy           -385 B  (-0.2%)     -154 B  (-0.3%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~882 bytes removed 📉 [gzipped])

name                  parsed_size             gzip_size
blog                      -1723 B  (deleted)     -873 B  (deleted)
update-design-flow          -12 B    (-0.0%)       -2 B    (-0.0%)
link-in-bio-tld-flow        -12 B    (-0.0%)       -5 B    (-0.0%)
copy-site-flow              -12 B    (-0.0%)       -2 B    (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~7 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains        -12 B  (-0.0%)       -7 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@xavier-lc xavier-lc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described

@rcrdortiz
Copy link
Contributor

Created a PR to handle redirections outside of the stepper framework here:

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/blog-tailored-flow on your sandbox.

@mmtr mmtr merged commit 3f6d739 into trunk Oct 24, 2024
9 of 11 checks passed
@mmtr mmtr deleted the remove/blog-tailored-flow branch October 24, 2024 09:22
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants