Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White-labeled plugin: Remove feature flag and translation checks for strings #95557

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

sixhours
Copy link
Contributor

Related to #95154

Proposed Changes

  • Remove translation and feature-flag checks for string changes in the migration flow.

Why are these changes being made?

  • Because we have translations for all mag 16 languages and the feature flag is no longer necessary.

Testing Instructions

  • Switch to this PR
  • Navigate to /start
  • Choose import an existing site at the goals step
  • Choose "Migrate site"
  • Choose "I'll do it myself"
  • Check out.
  • Ensure the migration instructions screen still works as expected.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@sixhours sixhours added the [Feature] Site Migration Features related to site migrations to WPcom label Oct 21, 2024
@sixhours sixhours requested a review from a team October 21, 2024 16:40
@sixhours sixhours self-assigned this Oct 21, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 21, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/translations-white-labeled-plugins on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sixhours sixhours merged commit 7b565ce into trunk Oct 21, 2024
14 of 15 checks passed
@sixhours sixhours deleted the update/translations-white-labeled-plugins branch October 21, 2024 17:06
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Migration Features related to site migrations to WPcom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants