-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding DataViews to Plugin Management #95561
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~79 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~16444 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~4947 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
And as @zaguiini mentioned elsewhere, if the loading of the plugins is fast enough, we could consider showing all the plugins instead of pagination... tbd I guess! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests looks good so far. I'm not certain how to access it on jetpack cloud. I can't seem to access the jetpack dashboard
I think I might need to make myself a Jetpack Agency to access Jetpack Manage Dashboard
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
padding: 0; | ||
body.is-section-plugins .plugin-management-wrapper, | ||
.is-section-jetpack-cloud-plugin-management { | ||
--wp-components-color-accent: var(--studio-automattic-blue-50); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could replace this line by this import import 'calypso/a8c-for-agencies/style.scss';
but doing that would bring other problems since that style is not fully reusable. This is an opportunity for further refactoring supporting A4A, Dotcom and Jetpack cloud.
max-width: 35px; | ||
max-height: 35px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could remove this CSS, but the icon would have 56px, which is too big for this screen. It would come from this file.
I updated the description @vykes-mac to help with that. Thanks for testing it! |
Project related: pet6gk-1CP-p2
Task related to https://github.com/Automattic/dotcom-forge/issues/9364
Proposed Changes
TODOs
Testing Instructions
For testing on Jetpack.cloud
partner_type
==agency
. Run this query to check (WPSH):return get_jetpack_partner_types( USER_ID )
a4a_agency
partner_type, you can use a different user and signup in the form aboveIn case you need more details, you may find this P2 useful: pet6gk-1Gs-p2
Pre-merge Checklist