Avoid getTheme call when slug is null #95570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
matticbot
added
the
[Status] Needs Review
lsl
commented
Oct 22, 2024
| previewingThemeSlug, | ||
| previewingThemeName: undefined, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Using both approaches to be a little more defensive with this hook, only one is technically needed.
taipeicoder
approved these changes
Oct 22, 2024
arthur791004
approved these changes
Oct 22, 2024
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to # p55Cj4-3EI-p2
Proposed Changes
Prevents unnecessary call to wp/v2/sites/:site/themes
Why are these changes being made?
When there is no theme being previewed and theme slug was undefined the
getThemecall was makes a fallback call to get all themes instead of just the one theme. This call takes 10s on dotcom and was blocking the site editor from rendering.Testing Instructions
Confirm only one theme call is made on site editor load:
yarn dev --syncorinstall-plugin.sh wpcom-block-editor update/themes-previewAlso confirm live preview still renders correctly:
Before
After