Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Fix purchase page for site-less flow #95646

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

dognose24
Copy link
Contributor

Related to p1729743194369679-slack-C1T3N5AMR

Proposed Changes

  • Revert the change of wrapping StatsPurchasePage with StatsPageLoader where we check site access permissions because it would forbid site-less purchases.

Why are these changes being made?

  • The site-less Stats purchase flow was not accessible because of the permission check in StatsPageLoader. The purchase page should be open to visiting without selected sites.

Testing Instructions

  • Spin this change up with the Calypso Live branch.
  • Navigate to the Stats purchase page without selected sites: /stats/purchase.
  • Ensure the purchase page displays.
截圖 2024-10-24 下午1 01 38
  • Click the Get Stats to grow my site button to purchase the license.
  • Ensure the redirecting checkout page is running for a site-less purchase flow: https://wordpress.com/checkout/jetpack/jetpack_stats_yearly

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@dognose24 dognose24 added the Stats Everything related to our analytics product at /stats/ label Oct 24, 2024
@dognose24 dognose24 requested a review from a team October 24, 2024 05:02
@dognose24 dognose24 self-assigned this Oct 24, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 24, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats        -23 B  (-0.0%)       +1 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~10 bytes added 📈 [gzipped])

name                                              parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-purchase        +83 B  (+0.1%)      +10 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@dognose24 dognose24 merged commit c0da961 into trunk Oct 24, 2024
14 of 15 checks passed
@dognose24 dognose24 deleted the fix/stats_purchase_site_less_flow branch October 24, 2024 05:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 24, 2024
Copy link
Contributor

@a8ck3n a8ck3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me. Thanks @dognose24!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants