Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hosting-features): refetching of useSiteTransferStatusQuery should be automatic, instead of manual #95666

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

nightnei
Copy link
Contributor

@nightnei nightnei commented Oct 24, 2024

Proposed Changes

It's follow up to this PR, specifically:

  1. rename isTransferInProgress to shouldRenderActivatingCopy
  2. rewrite manual refetching with internal automatic way

Testing Instructions

A4A tests

  1. Open https://agencies.automattic.com/
  2. Purchase licences, if you don't have (Left sidebar "Purchase" -> "Issue New License")
  3. Click on Sites in left sidebar
  4. Click on "Needs setup"
  5. Click on "Create new site" and proceed
  6. Wait till you see the next notification
    Screenshot 2024-08-13 at 12 58 24
  7. Copy selected domain on the screenshot above
  8. And open new tab with the next URL http://calypso.localhost:3000/hosting-features/<COPYED_DOMAIN_IN_7TH_STEP>
  9. Assert that you see spinner and copy about "things in progress"
    Screenshot 2024-08-13 at 13 00 43
  10. Wait till it's finished
  11. Assert that you are redirected to "Server Settings" tab

Manually turning on Hosting Features

  1. Purchase domain with Starter plan
  2. Open "Hosting features" tab on "Sites" page (Let's call this tab as A during testing)
  3. Copy the URL and open a separate tab (Let's call this tab as B during testing, we will use it in the end for testing)
  4. In tab A, click Upgrade now and proceed with upgrading
  5. Now let's repeat the 3-rd step to open one more separate tab (Let's call this tab as C during testing, we will use it in the end for testing), so that you will have the next tabs B and C:
    Screenshot 2024-07-29 at 16 12 45
  6. Now, in tab A click Activate now and proceed
  7. During activating process, the copy on tabs B and C should be changed to the next (with CTA buttons hidden)
    Screenshot 2024-07-29 at 16 15 28
  8. Wait till it's finished
  9. Assert that you are redirected to "Overview" tab

@matticbot
Copy link
Contributor

matticbot commented Oct 24, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~417 bytes removed 📉 [gzipped])

name              parsed_size           gzip_size
hosting-features      -1279 B  (-0.1%)     -417 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug nightnei/refactorHostingFeaturesFetchings on your sandbox.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 24, 2024
@nightnei nightnei self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants