Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailored Flows: Remove redirect to launchpad for removed flows #95669

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Oct 24, 2024

Fixes #95667

Proposed Changes

Prevents the redirection from /home/:site to /setup/:flow/launchpad if the site was created with one of the flows we have removed as part of https://github.com/Automattic/dotcom-forge/issues/8999.

Before

Screen.Recording.2024-10-24.at.12.17.54.mov

After

Screen.Recording.2024-10-24.at.14.28.56.mov

Why are these changes being made?

Because unlaunched sites created with a removed tailored flow were getting a broken experience

Testing Instructions

  • If you don't have a site created with one of the removed tailored flows, run this on your sandbox:
update_blog_option( <SITE_ID>, 'site_intent', 'free' );
  • Make sure the site is unlaunched and has not skipped/completed the launchpad
  • Use the Calypso live link below
  • Go to /sites
  • Pick the site and click on the "My Home" button
  • Make sure you stay on My Home and are not redirected to /setup/:flow/launchpad

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mmtr mmtr added the [Feature] Tailored Onboarding Flows All onbaording flows targeted to a specific marketshare / audience. label Oct 24, 2024
@mmtr mmtr requested a review from a team October 24, 2024 12:39
@mmtr mmtr self-assigned this Oct 24, 2024
@mmtr mmtr requested a review from a team as a code owner October 24, 2024 12:39
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 24, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 24, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~43 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +254 B  (+0.0%)      +43 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~457 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
home                                    +882 B  (+0.1%)     +329 B  (+0.1%)
themes                                   +20 B  (+0.0%)      +11 B  (+0.0%)
theme                                    +20 B  (+0.0%)      +11 B  (+0.0%)
staging-site                             +20 B  (+0.0%)      +11 B  (+0.0%)
sites-dashboard                          +20 B  (+0.0%)      +11 B  (+0.0%)
site-purchases                           +20 B  (+0.0%)      +11 B  (+0.0%)
site-performance                         +20 B  (+0.0%)      +11 B  (+0.0%)
site-monitoring                          +20 B  (+0.0%)      +11 B  (+0.0%)
site-logs                                +20 B  (+0.0%)      +11 B  (+0.0%)
site-blocks                              +20 B  (+0.0%)      +11 B  (+0.0%)
signup                                   +20 B  (+0.0%)      +13 B  (+0.0%)
settings                                 +20 B  (+0.0%)      +11 B  (+0.0%)
security                                 +20 B  (+0.0%)      +11 B  (+0.0%)
purchases                                +20 B  (+0.0%)      +11 B  (+0.0%)
privacy                                  +20 B  (+0.0%)      +11 B  (+0.0%)
plugins                                  +20 B  (+0.0%)       +9 B  (+0.0%)
plans                                    +20 B  (+0.0%)      +11 B  (+0.0%)
notification-settings                    +20 B  (+0.0%)      +11 B  (+0.0%)
me                                       +20 B  (+0.0%)      +11 B  (+0.0%)
marketplace                              +20 B  (+0.0%)      +11 B  (+0.0%)
jetpack-connect                          +20 B  (+0.0%)      +10 B  (+0.0%)
jetpack-cloud-settings                   +20 B  (+0.0%)       +9 B  (+0.0%)
jetpack-cloud-pricing                    +20 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-features-comparison        +20 B  (+0.0%)      +10 B  (+0.0%)
jetpack-app                              +20 B  (+0.0%)      +11 B  (+0.0%)
hosting-features                         +20 B  (+0.0%)      +11 B  (+0.0%)
hosting                                  +20 B  (+0.0%)      +11 B  (+0.0%)
help                                     +20 B  (+0.0%)      +11 B  (+0.0%)
github-deployments                       +20 B  (+0.0%)      +11 B  (+0.0%)
email                                    +20 B  (+0.0%)      +11 B  (+0.0%)
domains                                  +20 B  (+0.0%)      +11 B  (+0.0%)
developer                                +20 B  (+0.0%)      +11 B  (+0.0%)
checkout                                 +20 B  (+0.0%)      +11 B  (+0.0%)
account-close                            +20 B  (+0.0%)      +11 B  (+0.0%)
account                                  +20 B  (+0.0%)      +11 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~59 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-purchase-modal-wrapper                                                       +20 B  (+0.0%)      +10 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +20 B  (+0.0%)       +9 B  (+0.0%)
async-load-design-blocks                                                                +20 B  (+0.0%)      +12 B  (+0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice                        +20 B  (+0.1%)       +9 B  (+0.1%)
async-load-calypso-layout-masterbar-checkout                                            +20 B  (+0.0%)      +11 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                                         +20 B  (+0.0%)       +8 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/launchpad-redirect-removed-flows on your sandbox.

Copy link
Contributor

@xavier-lc xavier-lc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described.

client/landing/stepper/utils/flow-redirect-handler.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@rcrdortiz rcrdortiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks for the changes.

@mmtr mmtr merged commit 7b5dcd6 into trunk Oct 24, 2024
11 checks passed
@mmtr mmtr deleted the remove/launchpad-redirect-removed-flows branch October 24, 2024 14:22
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Tailored Onboarding Flows All onbaording flows targeted to a specific marketshare / audience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailored Flows: Unlaunched sites are redirected to /start
4 participants