Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging sites: Update learn logo on My Home #95670

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+9 −1
Open

Staging sites: Update learn logo on My Home #95670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions client/assets/images/customer-home/illustration--secondary-learn.svg
View file
Open in desktop
Copy link
Contributor

@fredrikekelund fredrikekelund Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really impact Calypso negatively, but the fact that the actual logo is off-center in the view box looks kind of odd on its own.

@matt-west, was this intentional on your part? That the logo should be vertically centered to the subheader, or something like that..?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it is a bit strange but I am guessing because it contains text (compared to all other graphics), perhaps it might be intentional to avoid it looking too cluttered. I am not exactly sure

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed client/assets/images/customer-home/illustration--secondary-wp-learn.png
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion client/my-sites/customer-home/cards/education/wpcourses/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import config from '@automattic/calypso-config';
import { useTranslate } from 'i18n-calypso';
import wpLearnLogo from 'calypso/assets/images/customer-home/illustration--secondary-wp-learn.png';
import wpLearnLogo from 'calypso/assets/images/customer-home/illustration--secondary-learn.svg';
import { EDUCATION_WPCOURSES } from 'calypso/my-sites/customer-home/cards/constants';
import EducationalContent from '../educational-content';

Expand Down
Loading