-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sites Dashboard: Add migration status to site header #95671
base: add/site-overview-pending-migration
Are you sure you want to change the base?
Sites Dashboard: Add migration status to site header #95671
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~211 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1829 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~50 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
const isMigrationPending = getMigrationStatus( site ) === 'pending'; | ||
const siteTitle = isMigrationPending ? translate( 'Incoming Migration' ) : site.title; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the site title being updated to "Incoming Migration" when the migration status is "started". In the design, it's updated only when the status is "pending".
Resolves #95589
Based on #95497
Proposed Changes
Testing Instructions
/sites
, click on the blog, and make sure the site heading has the "Incoming Migration" title, custom icon, and the "migration pending" status added to it.Pre-merge Checklist