Reader: Ensure URL Scheme in Subscription List Component

[eoigal]

Related to #95624

The curated list URLs do not have 'http://' prefixes which means that the Subscribe API requests fail with the following error;

{
    "code": 200,
    "headers": [
        {
            "name": "Content-Type",
            "value": "application\/json"
        }
    ],
    "body": {
        "info": "invalid_url",
        "subscribed": false
    }
}

This code change adds logic to ensure that the url property in the component always includes a proper URL scheme (i.e., http:// or https://).

If ownProps.url already starts with http:// or https://, it will be left unchanged. However, if the URL doesn't start with a valid scheme, http:// is prepended to it. This change is applied in the connect function, which manages the component's data connection to the state and props.

This ensures that the url is always a valid, complete URL when passed to the component.

Proposed Changes

• Adds http:// to site URL if missing - this is needed when subscribing to a site

Why are these changes being made?

Testing Instructions

• Using Calypso Live, go to /read?flags=reader/onboarding
• You can clear the preference flag to make the banner reappear by using the DEV tools found in the bottom right of the screen.

* Click on the `Discover and subscribe to sites you'll love` to open blog suggestions * Confirm you can subscribe to a blog * Confirm you can subscribe to a blog on the `/discover` popular blogs (in sidebar)

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-122694

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-122694&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-122694&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~36 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader        +56 B  (+0.0%)      +36 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~35 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks        +56 B  (+0.0%)      +35 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/onboarding-subscribe on your sandbox.

[allilevine]

Should we prepend https vs. http?

[allilevine]

This works, though I noticed that the curated list URLs are inconsistent -- some have it, some don't. With this PR we don't need to worry about it, but we could alternatively add the correct URL scheme to all of the URLs instead.

I also noticed some URLs that aren't URLs and opened a separate PR: #95686