Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment Methods: Remove Bank field from iDEAL Checkout #95682

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

JessBoctor
Copy link
Collaborator

@JessBoctor JessBoctor commented Oct 24, 2024

Related to # https://github.com/Automattic/payments-shilling/issues/3190

Proposed Changes

  • Remove the Bank form field from the iDEAL payment form fields ( Available to users with a valid Netherlands billing country and EUR currency).

Why are these changes being made?

  • Stripe reached out and let us know it would no longer be required:

To streamline the customer experience and to help increase conversion, iDEAL no longer requires merchants to display the bank selector in the checkout.

Testing Instructions

  • Load this branch
  • Set user currency to EUR
  • Add a product to your shopping cart
  • Set Billing Information > Country to Netherlands and use a valid postal code (example 1011 AH)
  • From Payment Information click on Edit and then select iDEAL
  • You should only see the Name field
Screenshot 2024-10-24 at 10 50 37

For complete testing instructions, including a test Checkout, see code-D164607

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@JessBoctor JessBoctor requested a review from a team as a code owner October 24, 2024 15:57
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 24, 2024
@JessBoctor JessBoctor self-assigned this Oct 24, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug gh3190/remove/ideal-bank-form-field on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~3162 bytes removed 📉 [gzipped])

name            parsed_size           gzip_size
site-purchases      -3615 B  (-0.2%)    -1521 B  (-0.4%)
purchases           -3615 B  (-0.2%)    -1521 B  (-0.3%)
checkout            -3615 B  (-0.2%)    -1641 B  (-0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1641 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal           -3615 B  (-0.3%)    -1641 B  (-0.5%)
async-load-calypso-blocks-editor-checkout-modal      -3615 B  (-0.3%)    -1641 B  (-0.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Payment Blocks Payment Methods Quick Fix [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants